Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmake build shouldn't pass /NODEFAULTLIB flag when LIBC in ON #2446

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 0 comments
Closed

Cmake build shouldn't pass /NODEFAULTLIB flag when LIBC in ON #2446

SDLBugzilla opened this issue Feb 11, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: 2.0.5
Reported for operating system, platform: Windows 10, All

Comments on the original bug report:

On 2017-04-29 16:33:18 +0000, wrote:

When compiling with CMake/MSVC, use of standard C library is disabled by defualt. I can enable it by passing -DLIBC=ON option to CMake, but as /NODEFAULTLIB is unconditionally passed to the linker, this results in unresolved symbol errors. The solution should be to simply don't pass pass any linker flags when use of stdlib was explicitly requested.
I'm not sure what's the best way to contribute to the project, so I'm attaching relevant patch here.

On 2017-04-29 16:34:18 +0000, wrote:

Created attachment 2727
Patch

On 2017-06-06 17:39:51 +0000, Ryan C. Gordon wrote:

This patch is now https://hg.libsdl.org/SDL/rev/61401688628e, thanks!

--ryan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant