Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmakelists completly broken in latest cmake/macos/xcode combo #2432

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 0 comments
Closed

cmakelists completly broken in latest cmake/macos/xcode combo #2432

SDLBugzilla opened this issue Feb 11, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: don't know
Reported for operating system, platform: macOS 10.13, x86_64

Comments on the original bug report:

On 2017-04-07 18:34:48 +0000, wrote:

Created attachment 2716
THE FIX

Using the latest xcode 8.3, latest mac os, latest svn sdl2 from github mirror.

Everything goes fine until the link stage.

At link stage xcode complains that it can't find Cocoa and Carbon. If you manually remove those two in the build settings it then complains about that undefined macro.

Here is how I personally fixed it: By editing the cmakelists myself with the following C++ code. It works because xcode can now automaticaly find all the frameworks it needs, and I simply replace the bad undefined macro to a good one. I use the C++ code so it auto fixes SDL2's cmakelists every time I check out a new version

I attached my fix in a txt file.

Thanks

On 2017-06-08 13:54:47 +0000, nikolay wrote:

Possible fix. Changed CMakelist.txt
Add frameworks based on target (osx/ios).

See SDL_Build_Bug_3625.diff attachment.

On 2017-06-08 13:55:46 +0000, nikolay wrote:

Created attachment 2755
Possible fix

On 2017-08-09 05:25:36 +0000, Ryan C. Gordon wrote:

(Sorry if you get a lot of copies of this email, we're touching dozens of bug reports right now.)

Tagging a bunch of bugs as target-2.0.6.

This means we're in the final stretch for an official SDL 2.0.6 release! These are the bugs we really want to fix before shipping if humanly possible.

That being said, we don't promise to fix them because of this tag, we just want to make sure we don't forget to deal with them before we bless a final 2.0.6 release, and generally be organized about what we're aiming to ship. After some debate, we might just remove this tag again and deal with it for a later release.

Hopefully you'll hear more about this bug soon. If you have more information (including "this got fixed at some point, nevermind"), we would love to have you come add more information to the bug report when you have a moment.

Thanks!
--ryan.

On 2017-08-16 06:01:42 +0000, Ryan C. Gordon wrote:

I'll be exploring this shortly, but it's worth noting that the "Xcode" directory has a real custom Xcode project for SDL, so you don't have to generate one with CMake.

--ryan.

On 2017-08-19 00:26:57 +0000, Ryan C. Gordon wrote:

Both these issues should be fixed by https://hg.libsdl.org/SDL/rev/670978408a10 and a few patches committed before it.

--ryan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant