We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3590 - CMAKE: typos in CheckMir
Summary: CMAKE: typos in CheckMir
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: build (show other bugs)
Version: HG 2.1
Hardware: All Linux
: P2 normal
Assignee: Brandon Schaefer
QA Contact: Sam Lantinga
URL:
Keywords: target-2.0.6
Depends on:
Blocks:
 
Reported: 2017-02-26 10:55 UTC by Martin Gerhardy
Modified: 2017-08-10 01:48 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Gerhardy 2017-02-26 10:55:36 UTC 
-            list(APPEND EXTRA_CFLAGS ${MIR_TOOLKIT_CFLAGS} ${EGL_CLFAGS} ${XKB_CLFLAGS})
+            list(APPEND EXTRA_CFLAGS ${MIR_TOOLKIT_CFLAGS} ${EGL_CFLAGS} ${XKB_CFLAGS})
 
CFLAGS is spelled wrong in two different ways for EGL and XKB
Comment 1 Martin Gerhardy 2017-02-26 11:31:32 UTC 
And while you are on it...

sdl needs mir >= 0.24 afaik - it fails on travis-ci (ubuntu 14.04 LTS with 0.18 installed and in other environments, too (e.g. https://github.com/urho3d/Urho3D/issues/1685)

To fix this one should add a min version check to pkg_check_modules like this

-        pkg_check_modules(MIR_TOOLKIT mirclient mircommon)
+        pkg_check_modules(MIR_TOOLKIT mirclient>=0.24 mircommon)
Comment 2 Martin Gerhardy 2017-02-26 11:33:17 UTC 
Oh, just checked the configure.in file - there version 0.25 is needed (some touch event stuff)
Comment 3 Brandon Schaefer 2017-08-02 19:51:22 UTC 
I need to clean up the CMake version for Mir as I've mainly been doing autotools. Ill take a look around, thanks for reporting!
Comment 4 Ryan C. Gordon 2017-08-09 05:33:17 UTC 
(Sorry if you get a lot of copies of this email, we're touching dozens of bug reports right now.)

Tagging a bunch of bugs as target-2.0.6.

This means we're in the final stretch for an official SDL 2.0.6 release! These are the bugs we really want to fix before shipping if humanly possible.

That being said, we don't promise to fix them because of this tag, we just want to make sure we don't forget to deal with them before we bless a final 2.0.6 release, and generally be organized about what we're aiming to ship. After some debate, we might just remove this tag again and deal with it for a later release.

Hopefully you'll hear more about this bug soon. If you have more information (including "this got fixed at some point, nevermind"), we would love to have you come add more information to the bug report when you have a moment.

Thanks!
--ryan.
Comment 5 Sam Lantinga 2017-08-10 01:48:27 UTC 
Fixed, thanks!
https://hg.libsdl.org/SDL/rev/1374cc1666db