Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMAKE: typos in CheckMir #2401

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 0 comments
Closed

CMAKE: typos in CheckMir #2401

SDLBugzilla opened this issue Feb 11, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

Reported in version: HG 2.1
Reported for operating system, platform: Linux, All

Comments on the original bug report:

On 2017-02-26 10:55:36 +0000, Martin Gerhardy wrote:

  •        list(APPEND EXTRA_CFLAGS ${MIR_TOOLKIT_CFLAGS} ${EGL_CLFAGS} ${XKB_CLFLAGS})
    
  •        list(APPEND EXTRA_CFLAGS ${MIR_TOOLKIT_CFLAGS} ${EGL_CFLAGS} ${XKB_CFLAGS})
    

CFLAGS is spelled wrong in two different ways for EGL and XKB

On 2017-02-26 11:31:32 +0000, Martin Gerhardy wrote:

And while you are on it...

sdl needs mir >= 0.24 afaik - it fails on travis-ci (ubuntu 14.04 LTS with 0.18 installed and in other environments, too (e.g. urho3d/urho3d#1685)

To fix this one should add a min version check to pkg_check_modules like this

  •    pkg_check_modules(MIR_TOOLKIT mirclient mircommon)
    
  •    pkg_check_modules(MIR_TOOLKIT mirclient>=0.24 mircommon)
    

On 2017-02-26 11:33:17 +0000, Martin Gerhardy wrote:

Oh, just checked the configure.in file - there version 0.25 is needed (some touch event stuff)

On 2017-08-02 19:51:22 +0000, Brandon Schaefer wrote:

I need to clean up the CMake version for Mir as I've mainly been doing autotools. Ill take a look around, thanks for reporting!

On 2017-08-09 05:33:17 +0000, Ryan C. Gordon wrote:

(Sorry if you get a lot of copies of this email, we're touching dozens of bug reports right now.)

Tagging a bunch of bugs as target-2.0.6.

This means we're in the final stretch for an official SDL 2.0.6 release! These are the bugs we really want to fix before shipping if humanly possible.

That being said, we don't promise to fix them because of this tag, we just want to make sure we don't forget to deal with them before we bless a final 2.0.6 release, and generally be organized about what we're aiming to ship. After some debate, we might just remove this tag again and deal with it for a later release.

Hopefully you'll hear more about this bug soon. If you have more information (including "this got fixed at some point, nevermind"), we would love to have you come add more information to the bug report when you have a moment.

Thanks!
--ryan.

On 2017-08-10 01:48:27 +0000, Sam Lantinga wrote:

Fixed, thanks!
https://hg.libsdl.org/SDL/rev/1374cc1666db

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant