Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X11 driver enables keyrepeat systemwide #2400

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 0 comments
Closed

X11 driver enables keyrepeat systemwide #2400

SDLBugzilla opened this issue Feb 11, 2021 · 0 comments
Assignees
Labels
early in milestone This change should be made early in the milestone for additional testing
Milestone

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

Reported in version: HG 2.1
Reported for operating system, platform: Linux, x86_64

Comments on the original bug report:

On 2017-02-17 05:56:03 +0000, Andrey Alexeyev wrote:

Subject. To reproduce: xset r off, make sure key repeat is indeed off, launch any SDL2 applicaion, key repeat is now enabled again. Probably shouldn't mess with the system's settings like this.

Removing the X11_XAutoRepeatOn call from X11_InitKeyboard in video/x11/SDL_x11keyboard.c should fix it, I think.

On 2018-08-07 18:17:15 +0000, Ryan C. Gordon wrote:

I'm inclined to say we shouldn't force autorepeat on. I don't think having it off will break anything (users will get a single, longer-held KEYDOWN event followed by a single KEYUP if they hold down a key, and SDL_TEXTINPUT won't repeat chars, of course), but this should only act differently if the user went out of their way to force it off anyhow, right?

This change happened here originally: https://hg.libsdl.org/SDL/rev/a7cbc25071b6

Sam: any opinions on this?

--ryan.

On 2020-04-09 22:05:39 +0000, wrote:

ping !

This is annoying, indeed.

@icculus icculus added this to the 2.0.22 milestone Feb 8, 2022
@icculus icculus self-assigned this Feb 8, 2022
@slouken slouken modified the milestones: 2.0.22, 2.0.24 Mar 17, 2022
@slouken slouken added the early in milestone This change should be made early in the milestone for additional testing label Mar 17, 2022
@slouken slouken assigned slouken and unassigned icculus Apr 26, 2022
icculus pushed a commit to icculus/SDL that referenced this issue Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
early in milestone This change should be made early in the milestone for additional testing
Projects
None yet
Development

No branches or pull requests

3 participants