We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3569 - GL_UpdateViewport leaves PROJECTION matrix selected
Summary: GL_UpdateViewport leaves PROJECTION matrix selected
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: render (show other bugs)
Version: HG 2.1
Hardware: x86_64 Windows 10
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-26 11:53 UTC by Tom Seddon
Modified: 2017-01-28 05:23 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Seddon 2017-01-26 11:53:02 UTC 
version: https://github.com/SDL-mirror/SDL/commit/0b5cd9831e112adc1a22a1dd7a87fcce336d6171

renderer: opengl

GL_ActivateRenderer may call GL_UpdateViewport, which leaves the GL_PROJECTION matrix selected. But after GL_ResetState, the GL_MODELVIEW matrix is selected, suggesting that's the intended default state.

It seems at least like these should be consistent. Presumably GL_UpdateViewport should be doing a glMatrixMode(GL_MODELVIEW) before it finishes.
Comment 1 Sam Lantinga 2017-01-28 05:23:50 UTC 
That seems reasonable. Implemented, thanks!
https://hg.libsdl.org/SDL/rev/71d8f9afb690