We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3560 - Joystick device not detected anymore
Summary: Joystick device not detected anymore
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: joystick (show other bugs)
Version: 2.0.4
Hardware: x86_64 Windows (All)
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-17 08:15 UTC by Mathieu Laurendeau
Modified: 2017-01-19 22:26 UTC (History)
0 users

See Also:

Attachments
Revert fix from bug 2460. (717 bytes, patch)
2017-01-18 09:25 UTC, Mathieu Laurendeau 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Laurendeau 2017-01-17 08:15:15 UTC 
This issue was reported on the GIMX forum: https://forum.gimx.fr/viewtopic.php?f=5&t=1976

I think this is a regression introduced in SDL 2.0.4 due to bug 2460. Bug 3005 also was a related regression.

My assumption is that the joystick device in question has type DI8DEVTYPE_SUPPLEMENTAL and subtype DI8DEVTYPESUPPLEMENTAL_THREEPEDALS.

https://msdn.microsoft.com/fr-fr/library/windows/desktop/microsoft.directx_sdk.reference.dideviceinstance(v=vs.85).aspx

> DI8DEVTYPE_SUPPLEMENTAL
> 
> Specialized device with functionality unsuitable for the main control of an
> application, such as pedals used with a wheel.

Three lines should be removed here:

https://hg.libsdl.org/SDL/file/161fee58e36f/src/joystick/windows/SDL_dinputjoystick.c#l345
Comment 1 Mathieu Laurendeau 2017-01-18 09:25:50 UTC 
Created attachment 2680 [details]
Revert fix from bug 2460.
Comment 2 Sam Lantinga 2017-01-18 20:21:42 UTC 
Fixed, thanks!
https://hg.libsdl.org/SDL/rev/b0559017b1e5
Comment 3 Mathieu Laurendeau 2017-01-19 08:52:12 UTC 
Thanks.
I can confirm that removing the filtering on devtype fixed the issue reported on the GIMX forum.

You probably forgot to remove the should_ignore variable since it is not used.
Comment 4 Sam Lantinga 2017-01-19 22:26:17 UTC 
Yep, got that, thanks.