We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3429 - Update AM_PATH_SDL2() to also check for SDL2.framework
Summary: Update AM_PATH_SDL2() to also check for SDL2.framework
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: build (show other bugs)
Version: HG 2.1
Hardware: All All
: P2 enhancement
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-19 20:05 UTC by neoaggelos
Modified: 2016-09-29 23:38 UTC (History)
0 users

See Also:

Attachments
patched sdl2.m4 (7.92 KB, text/plain)
2016-09-19 20:05 UTC, neoaggelos 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description neoaggelos 2016-09-19 20:05:38 UTC 
Created attachment 2565 [details]
patched sdl2.m4

It is common for Mac OS X to use the SDL2.framework instead of the classic UNIX dynamic lib.

Therefore, it makes sense for AM_PATH_SDL2() to be able to locate it. Attached is a patched sdl2.m4 (updated for that purpose).

Changes:
* look for SDL2.framework ONLY if pkg-config and sdl2-config tests failed (this is to ensure compatibility with the old behaviour)

* adds option ('--disable-sdlframework') to retreat to the old behaviour

* adds variable 'SDL2_FRAMEWORK' for the user to specify the exact path to SDL2.framework (e.g. if it is installed in a non-standard location)

Open to suggestions for further improvements
Comment 1 Sam Lantinga 2016-09-29 23:38:13 UTC 
Patch applied, thanks!
https://hg.libsdl.org/SDL/rev/9befd0acb9ef