We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 340 - DIB_FocusPalette foreground/background handling
Summary: DIB_FocusPalette foreground/background handling
Status: RESOLVED INVALID
Alias: None
Product: SDL
Classification: Unclassified
Component: video (show other bugs)
Version: HG 1.2
Hardware: x86 Windows (All)
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-08 14:55 UTC by Dmitry Yakimov
Modified: 2007-07-03 01:23 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Yakimov 2006-10-08 14:55:50 UTC 
Why in DIB_FocusPalette 'foreground' variable is not used?
I think it might be used in SelectPalette(hdc, screen_pal, !foreground), right?

It will help in case SDL window is a child window and there are some others windows that uses their own palette.
 
-- Dmitry
Comment 1 Sam Lantinga 2007-07-03 01:23:05 UTC 
As far as I can tell the third argument to SelectPalette() simply affects whether the call should try to change the display palette or just map to the display palette.  In our case we always want to change the display palette to the one we want.

I'm checking in new palette code shortly to improve SDL DIB palette handling.