We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3379 - Add gamecontrollerdb lines for SFC30 controller in various modes
Summary: Add gamecontrollerdb lines for SFC30 controller in various modes
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: joystick (show other bugs)
Version: HG 2.1
Hardware: x86 Other
: P2 enhancement
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-27 16:27 UTC by Jonathan Dowland
Modified: 2016-10-01 17:34 UTC (History)
0 users

See Also:

Attachments
Add gamecontrollerdb lines for SFC30 controller in various modes (3.75 KB, text/plain)
2016-06-27 16:27 UTC, Jonathan Dowland 		Details
Add gamecontrollerdb lines for SFC30 controller in various modes (5.39 KB, patch)
2016-06-28 13:29 UTC, Jonathan Dowland 		Details | Diff
Add gamecontrollerdb lines for SFC30 controller in various modes (5.12 KB, patch)
2016-07-01 15:48 UTC, Jonathan Dowland 		Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Dowland 2016-06-27 16:27:18 UTC 
Created attachment 2519 [details]
Add gamecontrollerdb lines for SFC30 controller in various modes

The SFC30 controller can present itself in a variety of modes and it offers
up different names in each. This patch captures data for three modes (two
bluetooth and one USB) on two platforms (Mac OS X and Linux). However, USB mode
on Linux is missing as the button events did not make it through to SDL's
controllermap tool on Fedora 24/Linux 4.5.5.

This patch incorporates the changes made in #84 (thanks @mariuszk911) and #80
(thanks @gingerbeardman) which are correct but not comprehensive. (I could have
just supplied the missing ones but each of these PRs are going to conflict
anyway)

There exists a similar controller called the SNES30 (And some others) that are
very likely identical except for the name, but I have not verified this yet so
haven't synthesized lines for those controllers until I can.

SFC30 controller: http://www.8bitdo.com/sfc30/
Comment 1 Jonathan Dowland 2016-06-27 16:28:27 UTC 
Oh, the middle para is copy-pasted from a PR I filed on github for an external controllerdb, os the issues it references and the names only make sense in that
context. (I did not copy the relevant lines from those people's PRs, I have generated them all myself using controllermap on three hosts)
Comment 2 Jonathan Dowland 2016-06-28 13:29:02 UTC 
Created attachment 2520 [details]
Add gamecontrollerdb lines for SFC30 controller in various modes
Comment 3 Jonathan Dowland 2016-06-28 13:29:26 UTC 
New patch adds a windows line via Steam Big Picture Mode
Comment 4 Jonathan Dowland 2016-07-01 15:40:09 UTC 
Some of the lines I add in the patch have the same GUID as each other, but different names. Looking through the SDL source, I guess the name is not that important, so the duplicate GUID lines can be removed -- is that right?  The only difference between the lines is the name. The lines were gathered from the controller in different modes (USB, bluetooth, and sub-modes thereof). The controller presents different names in those modes but the button mappings are the same.

For another project I'm working on that doesn't use the gamepad API (yet) the names do matter as it hooks onto joysticks by their names. That project will probably be moving to the gamepad API though.

Assuming the above is "yes", I will push a new patch with the dupe lines removed. Please let me know if my assumption is wrong.
Comment 5 Jonathan Dowland 2016-07-01 15:48:08 UTC 
Created attachment 2521 [details]
Add gamecontrollerdb lines for SFC30 controller in various modes
Comment 6 Sam Lantinga 2016-10-01 17:34:05 UTC 
Added, thanks!
https://hg.libsdl.org/SDL/rev/99bdc4fc41ba