We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3364 - Couldn't set hardware audio parameters: Success
Summary: Couldn't set hardware audio parameters: Success
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: audio (show other bugs)
Version: 2.0.4
Hardware: ARM Linux
: P2 minor
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-18 14:33 UTC by romain145
Modified: 2016-07-19 19:18 UTC (History)
1 user (show)

See Also:

Attachments
Diff (659 bytes, patch)
2016-06-18 14:33 UTC, romain145 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description romain145 2016-06-18 14:33:09 UTC 
Created attachment 2499 [details]
Diff

Just found a small omission where the status sent back after error "Couldn't set hardware audio parameters" is rather optimistic: "Success".

The reason is the missing return status value after the call to ALSA_set_period_size.

Before:
A failure in the init returns: "Couldn't set hardware audio parameters: Success"

After:
A failure in the init returns: "Couldn't set hardware audio parameters: Operation not permitted"

Please see attached diff file.
Thanks
Comment 1 Philipp Wiesemann 2016-07-19 19:18:58 UTC 
This patch is now https://hg.libsdl.org/SDL/rev/30ca8e64db6a, thanks!