We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3318 - testime.c enhancement with GNU Unifont support
Summary: testime.c enhancement with GNU Unifont support
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: *don't know* (show other bugs)
Version: HG 2.0
Hardware: All All
: P2 enhancement
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-04 09:56 UTC by Simon Hug
Modified: 2016-10-01 19:43 UTC (History)
0 users

See Also:

Attachments
testime.c GNU Unifont support (18.47 KB, patch)
2016-05-04 09:56 UTC, Simon Hug 		Details | Diff
testime.c GNU Unifont support (18.52 KB, patch)
2016-05-04 10:11 UTC, Simon Hug 		Details | Diff
testime.c GNU Unifont support (19.76 KB, patch)
2016-05-08 12:20 UTC, Simon Hug 		Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Hug 2016-05-04 09:56:27 UTC 
Created attachment 2439 [details]
testime.c GNU Unifont support

I'm proposing some changes to the IME test program test/testime.c. The patch includes support for the GNU Unifont hex file, making the SDL_ttf dependency optional. There were also one or two bugs that prevented the text and underline from showing up poperly.

An additional change is in src/test/SDL_test_common.c with the spacebar key event code. It's really annoying to input text if the spacebar opens a messagebox. This now only happens with control + spacebar. There are other keys that do something which make text input harder, but it's possible to work around them. Perhaps some option to disable these debugging helpers can be added at some other time to the SDLText framework. 

I tested it on Windows (8.1) and quickly on Linux (without an IME), but I don't have an OS X system. Maybe someone else can give it a go?
Comment 1 Simon Hug 2016-05-04 10:11:44 UTC 
Created attachment 2440 [details]
testime.c GNU Unifont support

I forgot to do the C89 pedantic test with the other patch. This one passes.
Comment 2 Simon Hug 2016-05-08 12:20:48 UTC 
Created attachment 2450 [details]
testime.c GNU Unifont support

I cleaned it up some more and added Supplemental Multilingual Plane support.
Comment 3 Sam Lantinga 2016-10-01 19:43:38 UTC 
Fixed, thanks!
https://hg.libsdl.org/SDL/rev/d6e839e8b339