This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

• dismiss keyboard patch (ios-keyboard-dismiss.patch, text/plain, 2016-04-05 15:27:40 +0000, 380 bytes)
• dismiss keyboard patch fix (ios-keyboard-dismiss-fix.patch, text/plain, 2016-12-01 19:54:01 +0000, 1891 bytes)
• dismiss keyboard and macro fix (ios-keyboard-dismiss-fix2.patch, text/plain, 2016-12-01 22:06:09 +0000, 2071 bytes)

Reported in version: HG 2.1
Reported for operating system, platform: iOS (All), iPhone/iPod touch

Comments on the original bug report:

On 2016-04-05 15:27:40 +0000, Diego wrote:

Created attachment 2407
dismiss keyboard patch

The keyboard on iPads has a dismiss button that hides the keyboard. When the keyboard was hidden using that button, instead of the return key, SDL was still reporting IsTextInputActive as true. This patch adds an extra SDL_StopTextInput when iOS reports the keyboard will hide.

On 2016-10-01 19:46:54 +0000, Sam Lantinga wrote:

Fixed, thanks!
https://hg.libsdl.org/SDL/rev/ff5f3b3e6940

On 2016-12-01 19:54:01 +0000, Diego wrote:

Created attachment 2642
dismiss keyboard patch fix

I was previously unaware that rotating the device to a different orientation when the keyboard is shown causes a keyboardWillHide followed by a keyboardWillShow notification. The previous patch would then mistakenly StopTextInput when rotating. This patch fixes that by checking if the device is rotating before stopping text input.

On 2016-12-01 19:55:15 +0000, Diego wrote:

Reopening

On 2016-12-01 22:06:09 +0000, Diego wrote:

Created attachment 2643
dismiss keyboard and macro fix

This update corrects and explains the deprecated macro check.

On 2016-12-02 10:22:00 +0000, Sam Lantinga wrote:

Good catch, thanks!