We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3294 - Can't compile SDL_qsort.c after the license change
Summary: Can't compile SDL_qsort.c after the license change
Status: RESOLVED DUPLICATE of bug 3296
Alias: None
Product: SDL
Classification: Unclassified
Component: main (show other bugs)
Version: HG 1.2
Hardware: All All
: P2 trivial
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-20 21:04 UTC by Ed Sinjiashvili
Modified: 2017-05-25 00:20 UTC (History)
1 user (show)

See Also:

Attachments
compile errors (2.90 KB, text/plain)
2016-03-20 21:04 UTC, Ed Sinjiashvili 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Sinjiashvili 2016-03-20 21:04:56 UTC 
Created attachment 2397 [details]
compile errors

It seems that two standard #includes have been removed during the license upgrade (2e3396e62aa6).
Adding them back fixes the build.

diff -r 2f1eb5fa26ea src/stdlib/SDL_qsort.c
--- a/src/stdlib/SDL_qsort.c	Fri Mar 11 08:30:18 2016 -0800
+++ b/src/stdlib/SDL_qsort.c	Sun Mar 20 23:38:24 2016 +0300
@@ -18,6 +18,9 @@
      misrepresented as being the original software.
   3. This notice may not be removed or altered from any source distribution.
 */
+#include "SDL_config.h"
+
+#include "SDL_stdinc.h"

 #ifndef HAVE_QSORT
Comment 1 Philipp Wiesemann 2016-03-23 20:54:29 UTC 
Bug 3296 has a similar patch.
Comment 2 Philipp Wiesemann 2016-03-31 21:45:26 UTC 
This was maybe fixed here (with a different patch):
https://hg.libsdl.org/SDL/rev/b1d2398f2655
Comment 3 Ryan C. Gordon 2017-05-25 00:20:07 UTC 
Yes, this is fixed.

*** This bug has been marked as a duplicate of bug 3296 ***