Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shaped windows creation and destruction #2128

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 1 comment · Fixed by #6446
Closed

Shaped windows creation and destruction #2128

SDLBugzilla opened this issue Feb 11, 2021 · 1 comment · Fixed by #6446
Assignees
@icculus
Milestone
2.26.0

Comments

@SDLBugzilla
Copy link
Collaborator

SDLBugzilla commented Feb 11, 2021 •
edited

This bug report was migrated from our old Bugzilla tracker.

Reported in version: HG 2.1
Reported for operating system, platform: All, All

Comments on the original bug report:

On 2016-03-15 18:22:10 +0000, Juha Niemimäki wrote:

There might be a couple of issues with shaped windows:

  1. SDL doesn't check the function pointers (like CreateShaper) before using ( https://hg.libsdl.org/SDL/file/9cec5fe32bca/src/video/SDL_shape.c#l38 )

  2. Cleanup: shouldn't shaper and data be cleaned during window destruction? Perhaps SDL_DestroyWindow could check for shaper existance, and when found, call a shaper destructor function?
@slouken slouken removed the bug label May 11, 2022
@icculus
Copy link
Collaborator

icculus commented Aug 22, 2022

NULL check was added in 0039499.

This bug is correct, we don't seem to free shaper stuff. We should fix that in SDL2, and decide if we even want the shaped window API in SDL3.

@icculus icculus self-assigned this Aug 22, 2022
@icculus icculus added this to the 2.26.0 milestone Aug 22, 2022
@slime73 slime73 mentioned this issue Aug 22, 2022
Closed
@slouken slouken modified the milestones: 2.26.0, 3.0 Oct 25, 2022
icculus added a commit to icculus/SDL that referenced this issue Oct 26, 2022
@icculus
shape: Free platform-specific shaped window data.
ce95804 
Fixes libsdl-org#2128.
@icculus icculus mentioned this issue Oct 26, 2022
Merged
icculus added a commit to icculus/SDL that referenced this issue Oct 26, 2022
@icculus
shape: Free platform-specific shaped window data.
e70abb8 
Fixes libsdl-org#2128.
icculus added a commit to icculus/SDL that referenced this issue Oct 26, 2022
@icculus
shape: Free platform-specific shaped window data.
62aab8d 
Fixes libsdl-org#2128.
icculus added a commit to icculus/SDL that referenced this issue Oct 26, 2022
@icculus
shape: Free platform-specific shaped window data.
d95da75 
Fixes libsdl-org#2128.
icculus added a commit that referenced this issue Oct 26, 2022
@icculus
shape: Free platform-specific shaped window data.
c8d20f9 
Fixes #2128.
sezero pushed a commit to sezero/SDL that referenced this issue Oct 28, 2022
@icculus @sezero
shape: Free platform-specific shaped window data.
dfeebcb 
Fixes libsdl-org#2128.

(cherry-picked from commit c8d20f9)
(cherry-picked from commit 41d38c0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@icculus icculus

Labels
None yet
Projects
None yet
Milestone
2.26.0
Development

Successfully merging a pull request may close this issue.

shape: Free platform-specific shaped window data. icculus/SDL
3 participants
@icculus @slouken @SDLBugzilla