This bug report was migrated from our old Bugzilla tracker.

Reported in version: 2.0.1
Reported for operating system, platform: All, All

Comments on the original bug report:

On 2016-03-15 18:11:45 +0000, Juha Niemimäki wrote:

I was testing SDL_image2 on AmigaOS 4 platform. Noticed a couple of issues with 'showimage' tool:

1. SDL_VideoInit seems to be called implicitly via window creation. SDL_Quit doesn't call SDL_VideoQuit so it doesn't close video device, windows etc. properly. Proposal: add SDL_Init(SDL_INIT_VIDEO) in the beginning for symmetrical video init/deinit.

2. Renderer is not destroyed at the end. As far as I know SDL2 doesn't automatically delete renderers. Proposal: add SDL_DestroyRenderer(renderer) at the end.

On 2017-09-11 19:48:22 +0000, Sylvain wrote:

Small patch for this:

--- a/showimage.c Sat Sep 09 18:57:05 2017 -0700
+++ b/showimage.c Mon Sep 11 21:47:56 2017 +0200
@@ -76,6 +76,11 @@
}
}

• if (SDL_Init(SDL_INIT_VIDEO) == -1) {

•    fprintf(stderr, "SDL_Init(SDL_INIT_VIDEO) failed: %s\n", SDL_GetError());
  

•    return(2);
  

• }

• if (SDL_CreateWindowAndRenderer(0, 0, flags, &window, &renderer) < 0) {
  fprintf(stderr, "SDL_CreateWindowAndRenderer() failed: %s\n", SDL_GetError());
  return(2);
  @@ -169,6 +174,10 @@
  SDL_DestroyTexture(texture);
  }

• SDL_DestroyRenderer(renderer);

• SDL_DestroyWindow(window);

• /* We're done! */
  SDL_Quit();
  return(0);

On 2017-09-12 04:23:18 +0000, Sam Lantinga wrote:

Fixed, thanks!
https://hg.libsdl.org/SDL_image/rev/28967769bc2e