Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] Add 'Libs.private' field to pkg-config file #211

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 1 comment
Closed

[PATCH] Add 'Libs.private' field to pkg-config file #211

SDLBugzilla opened this issue Feb 11, 2021 · 1 comment

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: 1.2.12
Reported for operating system, platform: All, All

Comments on the original bug report:

On 2016-03-01 01:50:35 +0000, Rodrigo Rebello wrote:

Created attachment 2388
Patch to add 'Libs.private' field to pkg-config file

In order to support static linking, SDL_mixer.pc should include a 'Libs.private' field listing all the libraries that SDL_mixer requires. This patch adds such a field.

On 2016-03-01 04:35:02 +0000, Rodrigo Rebello wrote:

Besides adding the mentioned field, the included patch also modifies configure.in so that EXTRA_LDFLAGS (which is now also used as the value of 'Libs.private') no longer includes SDL_LIBS. This is done so as to prevent libraries required by SDL from being listed twice when 'pkg-config --libs --static SDL_mixer' is run (they're already shown because of the 'Requires: sdl' line in SDL_mixer.pc). Makefile.in is also adjusted accordingly.

@sezero
Copy link
Contributor

sezero commented May 2, 2022

This should be fixed by #365 (and by #366 for the SDL-1.2 branch.)

@sezero sezero closed this as completed May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants