You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reported in version: 2.0.4 Reported for operating system, platform: Linux, x86_64
Comments on the original bug report:
On 2016-01-09 10:28:03 +0000, wrote:
Created attachment 2359
screenshot of spu2-x settings
Probably this will be for Ryan :)
Description/context: pcsx2 uses a plugin system, the plugin for sound is spu2x. The plugin uses SDL2. When using pulseaudio backend in SDL2, the sound is very bad (sound artefacts / crackling) since 2.0.4. If I switch to alsa backend, sound is fine. If I reinstall 2.0.3 lib32-sdl2 then sound is fine, as before, even when using the pulseaudio backend.
Reproduce: Not sure if it's system specific, but (assuming one is familiar with pcsx2) all you have to do is configure spu2x to use SDL audio & pulseaudio backend. I'll add a screenshot of the spu2x settings menu. The crackling is noticeable even from the bootup of the PS2 bios, so it's not game specific. I'm using PCSX2 built from git (1.3.1-20160105063026).
I tried to narrow it down a bit, reverse patching from 2.0.4 source and recompiling SDL2 but alas I didn't get very far, probably because I'm not familiar with Mercurial and didn't know exactly what patches or patchsets to use. I'm no programmer but if you have patches for me to test, I'll be glad to try them out!
Section: Return Value
If obtained is NULL, ...... If obtained is NULL, desired will have fields modified.
I think, we will rewrite the code to avoid this pitfall in the future. But it is annoying for already released version. And it might impact others project too.
On 2017-08-13 04:23:43 +0000, Ryan C. Gordon wrote:
If obtained is NULL, desired will have fields modified.
This phrase is bad in the wiki, but it does explain later on the page that it will only update fields like "silence" to be correct, and not actually change anything about the requested format. The intention was and always will be that if you specify "obtained" as NULL, you're saying "I must get the format requested in 'desired' because I can't handle anything but that format, so if you can't give me that format, pretend you did and have SDL convert for me transparently."
I have to look at the code to see if we're failing to do it this way, but that's the idea.
--ryan.
On 2017-08-13 19:56:03 +0000, Ryan C. Gordon wrote:
I'm not marking it as a duplicate yet, but Bug # 3749 is probably also a victim of this confusion.
--ryan.
On 2017-08-13 20:47:18 +0000, Ryan C. Gordon wrote:
I'm not marking it as a duplicate yet, but Bug # 3749 is probably also a
victim of this confusion.
Also Bug # 3710.
--ryan.
On 2017-08-14 19:05:19 +0000, wrote:
Hello,
you're saying "I must get the format requested in 'desired' because
I can't handle anything but that format, so if you can't give me that
format, pretend you did and have SDL convert for me transparently."
Yes it makes sense. It would be nice to update the wiki to state clearly the behavior of "NULL obtained" and which field is updated.
I think the confusion also came from SDL 2.0.3 which updated all desired field value.
On 2018-08-06 21:20:21 +0000, Ryan C. Gordon wrote:
Hello, and sorry if you're getting dozens of copies of this message by email.
We are closing out bugs that appear to be abandoned in some form. This can happen for lots of reasons: we couldn't reproduce it, conversation faded out, the bug was noted as fixed in a comment but we forgot to mark it resolved, the report is good but the fix is impractical, we fixed it a long time ago without realizing there was an associated report, etc.
Individually, any of these bugs might have a better resolution (such as WONTFIX or WORKSFORME or INVALID) but we've added a new resolution of ABANDONED to make this easily searchable and make it clear that it's not necessarily unreasonable to revive a given bug report.
So if this bug is still a going concern and you feel it should still be open: please feel free to reopen it! But unless you respond, we'd like to consider these bugs closed, as many of them are several years old and overwhelming our ability to prioritize recent issues.
(please note that hundred of bug reports were sorted through here, so we apologize for any human error. Just reopen the bug in that case!)
Thanks,
--ryan.
The text was updated successfully, but these errors were encountered:
This bug report was migrated from our old Bugzilla tracker.
These attachments are available in the static archive:
Reported in version: 2.0.4
Reported for operating system, platform: Linux, x86_64
Comments on the original bug report:
On 2016-01-09 10:28:03 +0000, wrote:
On 2016-01-11 13:27:53 +0000, wrote:
On 2016-01-24 12:12:31 +0000, wrote:
On 2016-01-24 15:03:56 +0000, wrote:
On 2016-01-24 16:28:07 +0000, Philipp Wiesemann wrote:
On 2016-01-24 17:14:14 +0000, wrote:
On 2017-08-13 04:23:43 +0000, Ryan C. Gordon wrote:
On 2017-08-13 19:56:03 +0000, Ryan C. Gordon wrote:
On 2017-08-13 20:47:18 +0000, Ryan C. Gordon wrote:
On 2017-08-14 19:05:19 +0000, wrote:
On 2018-08-06 21:20:21 +0000, Ryan C. Gordon wrote:
The text was updated successfully, but these errors were encountered: