We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3223 - SDL_GetDisplayDPI for OS X
Summary: SDL_GetDisplayDPI for OS X
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: video (show other bugs)
Version: 2.0.4
Hardware: x86 Mac OS X (All)
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-07 09:14 UTC by Kirill Dmitrenko
Modified: 2016-01-07 19:10 UTC (History)
2 users (show)

See Also:

Attachments
sdl-cocoa-dpi.patch (3.61 KB, text/plain)
2016-01-07 09:14 UTC, Kirill Dmitrenko 		Details
sdl-cocoa-dpi.patch (3.61 KB, patch)
2016-01-07 09:15 UTC, Kirill Dmitrenko 		Details | Diff
sdl-cocoa-dpi.patch (3.58 KB, patch)
2016-01-07 09:17 UTC, Kirill Dmitrenko 		Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kirill Dmitrenko 2016-01-07 09:14:24 UTC 
Created attachment 2356 [details]
sdl-cocoa-dpi.patch

It wasn't implemented. I took a look on X11 implementation and made something similar for Cocoa. Patch's attached.

I've also added the function to tests, but wasn't able to check it since I wasn't able to build the tests.
Comment 1 Kirill Dmitrenko 2016-01-07 09:15:54 UTC 
Created attachment 2357 [details]
sdl-cocoa-dpi.patch

Reattached patch as, em, a patch :)
Comment 2 Kirill Dmitrenko 2016-01-07 09:17:55 UTC 
Created attachment 2358 [details]
sdl-cocoa-dpi.patch

Removed forgotten include (it was added for debug).
Comment 3 Ryan C. Gordon 2016-01-07 19:10:52 UTC 
(In reply to Kirill Dmitrenko from comment #2)
> Removed forgotten include (it was added for debug).

This patch is now https://hg.libsdl.org/SDL/rev/2bab6f8d403e, thanks!

--ryan.