We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3214 - [PATCH] SDL_image causes "libpng warning: Interlace handling should be turned on when using png_read_image" when loading interlaced images
Summary: [PATCH] SDL_image causes "libpng warning: Interlace handling should be turned...
Status: RESOLVED FIXED
Alias: None
Product: SDL_image
Classification: Unclassified
Component: misc (show other bugs)
Version: 1.2.12
Hardware: x86 Other
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-26 14:39 UTC by Hans de Goede
Modified: 2018-03-02 13:50 UTC (History)
3 users (show)

See Also:

Attachments
SDL_image-1.2.12-interlaced-png-warning-fix.patch (1.84 KB, text/x-c)
2015-12-26 14:39 UTC, Hans de Goede 		Details
interlaced image (10.84 KB, image/png)
2017-09-13 08:32 UTC, Sylvain 		Details
patch (1.86 KB, patch)
2017-09-13 08:33 UTC, Sylvain 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hans de Goede 2015-12-26 14:39:18 UTC 
Created attachment 2346 [details]
SDL_image-1.2.12-interlaced-png-warning-fix.patch

Hi,

When starting an app which uses SDL_image to load interlaced png-s with a recent libpng, the following message is printed to the terminal:

libpng warning: Interlace handling should be turned on when using png_read_image

Once per loaded png. The attached patch fixes this.

Note this patch is for the 1.2 branch, but the same likely applies to 2.0 / master.

Regards,

Hans
Comment 1 Sylvain 2017-09-13 08:32:24 UTC 
Created attachment 2928 [details]
interlaced image
Comment 2 Sylvain 2017-09-13 08:33:59 UTC 
Created attachment 2929 [details]
patch

Same patch for SDL2_image, updated to head.
It does not seem to hurt and fixes this warning message.
Comment 4 Jhon Merced 2017-11-13 14:31:40 UTC 
@Hans also see this: https://www.internetvergelijken.nl
Comment 5 brianbrowns 2018-01-15 16:24:13 UTC 
Interesting Jhon. Have you seen that? https://promocode.com.ph/
Comment 6 Sam Lantinga 2018-02-07 22:21:17 UTC 
Fixed, thanks!
https://hg.libsdl.org/SDL_image/rev/71f0d661144f
Comment 7 Jhon Merced 2018-03-02 13:50:24 UTC 
Seems that everything's fixed here. http://zanuidiscountcode.com/