We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3208 - Minor improvements to the configure script
Summary: Minor improvements to the configure script
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: build (show other bugs)
Version: HG 2.0
Hardware: All Linux
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-19 13:09 UTC by Rafał Mużyło
Modified: 2017-08-12 22:01 UTC (History)
1 user (show)

See Also:

Attachments
the patch for described problems (6.71 KB, patch)
2015-12-19 13:09 UTC, Rafał Mużyło 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rafał Mużyło 2015-12-19 13:09:35 UTC 
Created attachment 2341 [details]
the patch for described problems

Due to testing for a problem with a different app (that wasn't caused by SDL after all), I've took at master of libsdl2 (which was at the time at a20484c998da).

The patch attached addresses a few minor build issues I've noticed:

- the define changes in configure.in are mostly cosmetic, due to non-compliant way AC_CONFIG_HEADER is used, still technically more correct

- the obvious typo in sdl2-config.cmake.in

- the remaining changes are simply cause "if we're already using libtool, why aren't we using it ?"; they've been inspired by the fact, that at that mark, neither libSDL2_test.a nor libSDL2main.a were being built correctly (not sure if it's fully broken or just because I've tested the out-of-tree build)
Comment 1 Ryan C. Gordon 2015-12-29 04:33:09 UTC 
I'm pulling in the small CMake fix for now, and will revisit the configure script changes after 2.0.4 has shipped; I'll leave this bug open and assigned to me until then.

The CMake fix is now https://hg.libsdl.org/SDL/rev/a80ea42a4adc, thanks!

--ryan.
Comment 2 Ryan C. Gordon 2015-12-29 07:20:05 UTC 
Just changing the summary text so I can find this easier, later.

--ryan.
Comment 3 Sam Lantinga 2017-08-12 22:01:41 UTC 
This is in, thanks!
https://hg.libsdl.org/SDL/rev/283194179512