We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3194 - CMake misses Android [Patch]
Summary: CMake misses Android [Patch]
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: build (show other bugs)
Version: HG 2.0
Hardware: All Android (All)
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-03 17:39 UTC by Martin Gerhardy
Modified: 2015-12-29 05:58 UTC (History)
1 user (show)

See Also:

Attachments
the patch for the cmake file (4.43 KB, patch)
2015-12-03 17:39 UTC, Martin Gerhardy 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Gerhardy 2015-12-03 17:39:45 UTC 
Created attachment 2321 [details]
the patch for the cmake file

If you are building SDL for android with cmake, some stuff is missing for it to work. The attached patch fixes some of the issues (more to come once time allows)
Comment 1 Martin Gerhardy 2015-12-06 11:12:36 UTC 
Will also need these patches to be applied to let cmake + android work properly:
https://bugzilla.libsdl.org/show_bug.cgi?id=3201
https://bugzilla.libsdl.org/show_bug.cgi?id=3200
https://bugzilla.libsdl.org/show_bug.cgi?id=3197

depending on cmake version and the toolchain you use - you might also have to apply this patch to the android toolchain cmake file: https://github.com/taka-no-me/android-cmake/pull/70 (for cmake >= 3.0.0)
Comment 2 Martin Gerhardy 2015-12-06 11:46:04 UTC 
ups - not the linked pr #70 - but this is needed for the android toolchain : https://github.com/taka-no-me/android-cmake/pull/73
Comment 3 Martin Gerhardy 2015-12-06 11:48:39 UTC 
And if someone is interested in a real world example - check out the commits around this one: https://github.com/mgerhardy/caveexpress/commits/1c5c62b328f4d49a2043f1509929591754e22aa4
Comment 4 Ryan C. Gordon 2015-12-29 05:58:35 UTC 
This patch is now https://hg.libsdl.org/SDL/rev/9145e51b15bb, thanks!

We'll sort out Bug #3200 over there.

--ryan.