Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake misses Android [Patch] #2036

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 0 comments
Closed

CMake misses Android [Patch] #2036

SDLBugzilla opened this issue Feb 11, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: HG 2.0
Reported for operating system, platform: Android (All), All

Comments on the original bug report:

On 2015-12-03 17:39:45 +0000, Martin Gerhardy wrote:

Created attachment 2321
the patch for the cmake file

If you are building SDL for android with cmake, some stuff is missing for it to work. The attached patch fixes some of the issues (more to come once time allows)

On 2015-12-06 11:12:36 +0000, Martin Gerhardy wrote:

Will also need these patches to be applied to let cmake + android work properly:
https://bugzilla.libsdl.org/show_bug.cgi?id=3201
https://bugzilla.libsdl.org/show_bug.cgi?id=3200
https://bugzilla.libsdl.org/show_bug.cgi?id=3197

depending on cmake version and the toolchain you use - you might also have to apply this patch to the android toolchain cmake file: taka-no-me/android-cmake#70 (for cmake >= 3.0.0)

On 2015-12-06 11:46:04 +0000, Martin Gerhardy wrote:

ups - not the linked pr # 70 - but this is needed for the android toolchain : taka-no-me/android-cmake#73

On 2015-12-06 11:48:39 +0000, Martin Gerhardy wrote:

And if someone is interested in a real world example - check out the commits around this one: https://github.com/mgerhardy/caveexpress/commits/1c5c62b328f4d49a2043f1509929591754e22aa4

On 2015-12-29 05:58:35 +0000, Ryan C. Gordon wrote:

This patch is now https://hg.libsdl.org/SDL/rev/9145e51b15bb, thanks!

We'll sort out Bug # 3200 over there.

--ryan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant