We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3172 - config.guess and config.sub should not be locally-modified
Summary: config.guess and config.sub should not be locally-modified
Status: NEW
Alias: None
Product: SDL
Classification: Unclassified
Component: build (show other bugs)
Version: HG 2.0
Hardware: All All
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-11 22:07 UTC by Yann Dirson
Modified: 2015-11-11 22:07 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yann Dirson 2015-11-11 22:07:24 UTC 
Those files are brought by autotools (automake --add-missing, autoreconf), and
the autotools maintainers update them regularly to add support for newer platforms.
This is why eg. most Debian packages (including the libsdl2 package) update them
using autoreconf while building (archs like *-kfreebsd or ppc64le-* for example
are not found by older config.* versions).

Today the SDL hg repo contains a very old version of those scripts (which means
many packagers have to override them), but modified.
If someone was to update those scripts in hg (which was last done in 2012), this
would interfere with the support for raspberrypi, emscripten, and "Chrome's native
client backend".

As far as I'm concerned, this means that building a libsdl2 package on Raspbian on
a rpi won't compile the RPI video driver.

config.* patches should be directed to their authors, GNU automake maintainers.
But here the rule that says that all boards featuring BCM2708 and BCM2709 running Linux
are RasperryPi's seems overreaching.

That value returned by the modified config.guess is used for 2 things:
* using the libs in /opt/vc, which could be better detected by a specific compilation test
  (checking for vc_dispmanx_resource_create ?)
* activating the RPI video driver, which could probably just depend on the result of
  the former test

... and thus at first sight it looks like the proper solution is just to use standard
autoconf checks, and that in fact no change to config.guess are needed.  Support for
the other two platforms will surely need to be adjusted similarly.


As a sidenote, keeping the generated files in the repository is what allowed the situation
to happen.  This is also the reason why in SDL2 trunk configure is desynchronized from
configure.in.  Many projects have chosen not to track those generated and copied files
to avoid those and other problems.