We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3127 - OSX deprecated Carbon Components Audio Unit warning
Summary: OSX deprecated Carbon Components Audio Unit warning
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: audio (show other bugs)
Version: HG 2.0
Hardware: x86 Mac OS X (All)
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks: 1756
  Show dependency treegraph
 
Reported: 2015-09-21 21:15 UTC by Dominik Reichardt
Modified: 2016-10-01 21:24 UTC (History)
2 users (show)

See Also:


Attachments
patch (2.38 KB, patch)
2015-09-21 21:15 UTC, Dominik Reichardt
Details | Diff
Patch for SDL 1.2x (1.60 KB, patch)
2015-09-21 22:14 UTC, Dominik Reichardt
Details | Diff
Patch for SDL2 - keeping support for OS X 10.5 (1.52 KB, patch)
2015-09-21 22:35 UTC, Dominik Reichardt
Details | Diff
Patch for SDL2 (2.00 KB, patch)
2015-09-21 22:36 UTC, Dominik Reichardt
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Reichardt 2015-09-21 21:15:34 UTC
Created attachment 2271 [details]
patch

With current SDL code you receive this warning in SDL apps:

WARNING: 140: This application, or a library it uses, is using the deprecated Carbon Component Manager for hosting Audio Units. Support for this will be removed in a future release. Also, this makes the host incompatible with version 3 audio units. Please transition to the API's in AudioComponent.h.

This is because the CoreAudio code is still using the pre-OSX-10.6 code. Since you are only supporting OS X >= 10.7 you can move away from this old code.

Attached patch seems to fix it. I only tested with Exult (exult.sf.net), with these changes it still builds and still produces sound with CoreAudio.

I'll see about making a patch for SDL 1.2x as well, since a lot of apps I build still use it and are not likely to switch unfortunately.
Comment 1 Dominik Reichardt 2015-09-21 22:14:26 UTC
Created attachment 2272 [details]
Patch for SDL 1.2x

I've added a patch for SDL 1.2x as well
Comment 2 Dominik Reichardt 2015-09-21 22:35:46 UTC
Created attachment 2273 [details]
Patch for SDL2 - keeping support for OS X 10.5

Added a second patch for SDL2 that keeps support for OS X 10.5 so SDL2 can still be deployed for that. Adds ugly 
#if MAC_OS_X_VERSION_MAX_ALLOWED <= 1050 
lines, though. :)
Comment 3 Dominik Reichardt 2015-09-21 22:36:47 UTC
Created attachment 2274 [details]
Patch for SDL2
Comment 4 Alex Szpakowski 2016-05-21 03:21:29 UTC
Applied with this commit: https://hg.libsdl.org/SDL/rev/3115d38204aa
Comment 5 Dominik Reichardt 2016-05-23 21:39:36 UTC
I wish you could apply this to the SDL-1.2 branch as well ;)
Comment 6 Alex Szpakowski 2016-05-23 21:52:49 UTC
SDL 1.2 is itself deprecated. The audio components warning is just a bonus :)
Comment 7 Dominik Reichardt 2016-05-23 22:02:10 UTC
Yeah, I know ;)
It's just because it still receives some bug fixes from time to time...
Comment 8 Sam Lantinga 2016-10-01 21:24:46 UTC
Marking resolved.