We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3068 - No X11 error handler protecting GL make current calls
Summary: No X11 error handler protecting GL make current calls
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: video (show other bugs)
Version: 2.0.3
Hardware: x86_64 Linux
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-23 18:40 UTC by Drew Bliss
Modified: 2015-07-28 04:15 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Drew Bliss 2015-07-23 18:40:26 UTC 
We had a user bug report that appears to be an X11 error during a GL make-current.

#6 0x00007ffff553d0c6 in _XDefaultError ()
from /home/bednar/.steam/ubuntu12_32/steam-runtime/amd64/usr/lib/x86_64-linux-gnu/libX11.so.6
#7 0x00007ffff7bc63fb in ?? ()
from /home/bednar/.steam/ubuntu12_64/gameoverlayrenderer.so
#8 0x00007ffff553d20f in _XError ()
from /home/bednar/.steam/ubuntu12_32/steam-runtime/amd64/usr/lib/x86_64-linux-gnu/libX11.so.6
#9 0x00007ffff553a1d1 in ?? ()
---Type to continue, or q to quit---
from /home/bednar/.steam/ubuntu12_32/steam-runtime/amd64/usr/lib/x86_64-linux-gnu/libX11.so.6
#10 0x00007ffff553b157 in _XReply ()
from /home/bednar/.steam/ubuntu12_32/steam-runtime/amd64/usr/lib/x86_64-linux-gnu/libX11.so.6
#11 0x00007ffff6c0168d in ?? () from /usr/lib/x86_64-linux-gnu/mesa/libGL.so.1
#12 0x00007ffff6c01851 in ?? () from /usr/lib/x86_64-linux-gnu/mesa/libGL.so.1
#13 0x00007ffff6be8469 in glXMakeCurrentReadSGI ()
from /usr/lib/x86_64-linux-gnu/mesa/libGL.so.1
#14 0x00007ffff09c7ee5 in ?? ()
from /home/bednar/.steam/steam/steamapps/common/dota 2 beta/game/bin/linuxsteamrt64/libSDL2-2.0.so.0

The root cause of the error may not be SDL but it would be nice to not have the default error handler shut the process down.  Some SDL spew on what the error is would be good too.
Comment 1 Ryan C. Gordon 2015-07-28 04:15:41 UTC 
This is fixed in https://hg.libsdl.org/SDL/rev/9b4dd9efb04e ...rather, it will probably return an error to the app in this scenario instead of killing the process.

SDL_GL_MakeCurrent() will return -1 and SDL_GetError() will then have the specific details when this sort of nasty error is thrown.

--ryan.