We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 3001 - CMake build broken on Windows
Summary: CMake build broken on Windows
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: build (show other bugs)
Version: HG 2.1
Hardware: x86_64 Windows 7
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords: target-2.0.4
Depends on:
Blocks:
 
Reported: 2015-06-04 17:02 UTC by Joe Thompson
Modified: 2015-06-08 00:16 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joe Thompson 2015-06-04 17:02:21 UTC 
The CMake generated solution fails to build (VS2010) since:
changeset 9658	9753468b5c0e
Move tests from SDL_config higher up in Windows joystick/haptic code.

DWORD is not defined.

#if SDL_HAPTIC_XINPUT was moved 
and now 
#include "../../joystick/windows/SDL_windowsjoystick_c.h" is not included which pulls in windef.h
Comment 1 Ryan C. Gordon 2015-06-07 22:30:21 UTC 
This is (maybe) fixed by https://hg.libsdl.org/SDL/rev/e501460cb4c4, can you sync up to the latest in revision control and see if it works for you now?

Thanks,
--ryan.
Comment 2 Joe Thompson 2015-06-07 23:19:43 UTC 
(In reply to Ryan C. Gordon from comment #1)
> This is (maybe) fixed by https://hg.libsdl.org/SDL/rev/e501460cb4c4, can you
> sync up to the latest in revision control and see if it works for you now?
> 
> Thanks,
> --ryan.

Thanks Ryan.
Builds fine now.
FYI: Don't know if it is intended but SDL_SHARED is "OFF" by default in the CMake configuration.
Thanks,
Joe
Comment 3 Ryan C. Gordon 2015-06-08 00:16:10 UTC 
(In reply to Joe Thompson from comment #2)
> Builds fine now.

Yay!

> FYI: Don't know if it is intended but SDL_SHARED is "OFF" by default in the
> CMake configuration.

Whoops, not intended. Fixed here, now: https://hg.libsdl.org/SDL/rev/45a632fd9d83

Thanks again,
--ryan.