This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

• PATCH (blit_copy_alpha.patch, text/plain, 2015-05-04 11:57:11 +0000, 2014 bytes)

Reported in version: HG 2.0
Reported for operating system, platform: All, All

Comments on the original bug report:

On 2015-05-04 11:57:11 +0000, id.zeta wrote:

Created attachment 2148
PATCH

The optimization from Bug 11 added a code branch on cases where the source RGB masks match the destination RGB masks and a optimized blit function Blit4to4MaskAlpha that always overrides the source alpha info would be chosen. Unfortunately, the branch also errorneously took over the RGBA<->RGBA blitting cases where the source alpha info should be copied, while they would instead get overriden in Blit4to4MaskAlpha.

The attached patch fixes that by handling the RGBA<->RGBA cases correctly in that branch with the original BlitNtoNCopyAlpha as well as uses an optimized Blit4to4CopyAlpha along the same vein.

On 2015-05-05 04:48:15 +0000, Sam Lantinga wrote:

Fixed, thanks!
https://hg.libsdl.org/SDL/rev/0bd764eb2b99

On 2015-05-27 06:47:33 +0000, Ozkan Sezer wrote:

Will this be ported back to SDL-1.2 ?

On 2015-05-28 19:14:31 +0000, Ryan C. Gordon wrote:

(In reply to Ozkan Sezer from comment # 2)

Will this be ported back to SDL-1.2 ?

Likely not.

Even if we put it in revision control, we have no intention to release an SDL 1.2.16.

--ryan.