We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2969 - Manual coding mistake in recompute_amp function
Summary: Manual coding mistake in recompute_amp function
Status: RESOLVED FIXED
Alias: None
Product: SDL_mixer
Classification: Unclassified
Component: misc (show other bugs)
Version: unspecified
Hardware: x86 Linux
: P2 major
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-01 10:04 UTC by Nitz
Modified: 2015-05-03 02:25 UTC (History)
0 users

See Also:

Attachments
Patch (565 bytes, patch)
2015-05-01 10:04 UTC, Nitz 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nitz 2015-05-01 10:04:05 UTC 
Created attachment 2143 [details]
Patch

In recompute_amp(int v) function:

under if condition:
if (note>0 && drumpanpot[chan][note]>=0) panning = drumvolume[chan][note];

This should be panning = drumpanpot[chan][note] instead of drumvolume.

Patch is attached.

Thanks!!!
Comment 1 Sam Lantinga 2015-05-03 02:25:27 UTC 
Fixed, thanks!
https://hg.libsdl.org/SDL_mixer/rev/30ff0c742ac7