Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable IPV6 feature in SDL_net 1.2.8. #28

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 4 comments
Closed

Enable IPV6 feature in SDL_net 1.2.8. #28

SDLBugzilla opened this issue Feb 11, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: 1.2.8
Reported for operating system, platform: Linux, x86

Comments on the original bug report:

On 2015-04-24 08:59:22 +0000, Nitz wrote:

Created attachment 2132
IPV6 Patch

Hi,
I have implemented IPV6 support in SDL_net-1.2.8 version,

which means if Server is dual stack then Server can communicate with IPV6 and IPV4 clients both at same time.

I have done best possible changes with optimization in SDL_net as all of the API signatures are same except SDLNet_UDP_Open

Kindly review and release the changes as per your policy.

If having any doubts please ask.

Attaching the Patch with IPV6 changes

Build steps:

export CPPFLAGS=-DDUAL_IP

./configure

make all

make install

On 2015-05-20 13:08:07 +0000, Nitz wrote:

(In reply to Nitz from comment # 0)

Created attachment 2132 [details]
IPV6 Patch

Hi,
I have implemented IPV6 support in SDL_net-1.2.8 version,

which means if Server is dual stack then Server can communicate with IPV6
and IPV4 clients both at same time.

I have done best possible changes with optimization in SDL_net as all of the
API signatures are same except SDLNet_UDP_Open

Kindly review and release the changes as per your policy.

If having any doubts please ask.

Attaching the Patch with IPV6 changes

Build steps:

export CPPFLAGS=-DDUAL_IP

./configure

make all

make install

On 2015-05-20 13:10:35 +0000, Nitz wrote:

Hi Mr.Sam,
Any updates regarding IPV6 enhancement in SDL_net?
Please feel free if having any doubts.

Regards,
Nitin

On 2015-07-22 09:06:08 +0000, Nitz wrote:

A gentle reminder!!!

Thanks...

On 2015-07-22 19:23:20 +0000, Philipp Wiesemann wrote:

Bug 283 also has patches for IPv6.

On 2015-07-23 03:50:42 +0000, Nitz wrote:

Yes. I have seen that but the patch which I suggested has minimal changes as compared to Bug 283 and important thing is API signatures are also same except SDLNet_UDP_Open.
You can compare and take the decision as currently I am using the same patch successfully.

On 2015-09-29 05:54:08 +0000, Nitz wrote:

A gentle reminder!!!
Thanks.

On 2016-08-03 00:20:39 +0000, wrote:

Created attachment 2536
updated patch for sdl2_net-2.0.1

I merged Nitz's patch with sdl2_net-2.0.1 and removed the #defines so the code isn't dependent on DUAL_IP being defined. It's not a very nice diff to look at, but perhaps it will save someone else some work.

I don't know much about IPv6 but I did test this against both IPv4 and IPv6 networks, and it seems to work fine.

On 2018-05-25 21:53:53 +0000, Eric wing wrote:

Just wondering what the status of IPv6 in SDL_net is. Apple's App Stores require IPv6 operability as of 2 years ago. They seem to have an automated way to test compliance so they can automatically reject IPv4 only apps.

So it would be really useful to have IPv6 support now.

@SopaDeMacaco-UmaDelicia

AYoooo, bump

@icculus icculus mentioned this issue Jun 17, 2023
@icculus
Copy link
Collaborator

icculus commented Jun 17, 2023

There is also a patch in #5, let's evaluate these both and see if either make sense.

@icculus
Copy link
Collaborator

icculus commented Jun 17, 2023

We're dumping this patch and figuring this out from-scratch in #40.

@icculus icculus closed this as not planned Won't fix, can't repro, duplicate, stale Jun 17, 2023
@slouken slouken reopened this Jun 17, 2023
@icculus
Copy link
Collaborator

icculus commented Sep 30, 2023

SDL3_net supports IPv6, so I'm calling this done.

@icculus icculus closed this as completed Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants