We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2934 - Wayland crash in wl_proxy_get_user_data
Summary: Wayland crash in wl_proxy_get_user_data
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: events (show other bugs)
Version: HG 2.1
Hardware: x86_64 Linux
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords: target-2.0.4
Depends on:
Blocks:
 
Reported: 2015-04-08 07:05 UTC by x414e54
Modified: 2015-05-28 04:19 UTC (History)
1 user (show)

See Also:

Attachments
Wayland Null Surface Fix (538 bytes, patch)
2015-04-10 10:55 UTC, x414e54 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description x414e54 2015-04-08 07:05:32 UTC 
It looks as though there is an issue in keyboard_handle_enter in SDL_waylandevents.c causing a SIGSEGV in wl_surface_get_user_data.

This seems to be because the surface is null due having been destroyed and the application still receives an event. 

It should check for !surface and return similar to how it does in pointer_handle_enter above in the same file.
Comment 1 x414e54 2015-04-10 10:55:55 UTC 
Created attachment 2115 [details]
Wayland Null Surface Fix

I have created a patch. It simply copies the same null surface handling from pointer_handle_enter to keyboard_handle_enter.
Comment 2 Ryan C. Gordon 2015-05-28 04:19:10 UTC 
This patch is now https://hg.libsdl.org/SDL/rev/5c55c6567bdc, thanks!

--ryan.