We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2933 - Silence -Wunused-value in SDL_assert.h.
Summary: Silence -Wunused-value in SDL_assert.h.
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: *don't know* (show other bugs)
Version: HG 2.1
Hardware: x86_64 Linux
: P2 minor
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-08 03:46 UTC by Rohit Nirmal
Modified: 2015-06-01 04:10 UTC (History)
0 users

See Also:

Attachments
Patch for SDL_assert.h (885 bytes, patch)
2015-04-08 03:47 UTC, Rohit Nirmal 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rohit Nirmal 2015-04-08 03:46:51 UTC 
The fix to bug 2733 (https://hg.libsdl.org/SDL/rev/d5925549bfe0) brings up several "left-hand operand of comma expression has no effect" warnings in gcc on my Antergos setup. Since the original fix was intended for MSVC, only use the fix for that platform.
Comment 1 Rohit Nirmal 2015-04-08 03:47:20 UTC 
Created attachment 2110 [details]
Patch for SDL_assert.h
Comment 2 Ryan C. Gordon 2015-06-01 04:10:41 UTC 
This was fixed (with basically the exact same patch) here:

https://hg.libsdl.org/SDL/rev/1c41db87ce20

Thanks!

--ryan.