Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows joystick and haptic c source files: wrong guards #1816

Closed
SDLBugzilla opened this issue Feb 10, 2021 · 0 comments
Closed

windows joystick and haptic c source files: wrong guards #1816

SDLBugzilla opened this issue Feb 10, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

Reported in version: HG 2.1
Reported for operating system, platform: Linux, x86_64

Comments on the original bug report:

On 2015-04-07 17:00:11 +0000, Martin Gerhardy wrote:

It's not possible to skip the files when you build for linux, because the guards are either wrongly placed or missing. Every other subsystems work - only joystick and haptic don't.

On 2015-04-08 01:44:00 +0000, Ryan C. Gordon wrote:

What should be there? I see "#if SDL_JOYSTICK_DINPUT" (etc) on each of the Windows files. I might be misunderstanding the issue here.

--ryan.

On 2015-04-08 06:38:02 +0000, Martin Gerhardy wrote:

The "problem" is that there are header inclusions above the guard(s). I think there should only be one header inclusion above the guards - the one that defines the guards.

Some of the "unprotected" header inclusions include windows.h at some place without a windows guard (which is fine - that's not my issue).

So basically it's all about moving the header inclusions into the guarded part except the one that defines the guard.

On 2015-04-09 05:39:20 +0000, Ryan C. Gordon wrote:

(In reply to Martin Gerhardy from comment # 2)

So basically it's all about moving the header inclusions into the guarded
part except the one that defines the guard.

Oh, I understand now. Ok, I'll try to fix that for 2.0.4.

--ryan.

On 2015-05-28 04:55:55 +0000, Ryan C. Gordon wrote:

Should be fixed by https://hg.libsdl.org/SDL/rev/9753468b5c0e, please let me know if it still causes you problems.

--ryan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant