We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2900 - CMake: Missing DirectX configuration
Summary: CMake: Missing DirectX configuration
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: build (show other bugs)
Version: HG 2.1
Hardware: x86_64 Windows 7
: P2 blocker
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords: target-2.0.4
Depends on:
Blocks:
 
Reported: 2015-03-09 09:21 UTC by MailMr_S
Modified: 2015-05-27 01:10 UTC (History)
3 users (show)

See Also:

Attachments
Patch to fix (745 bytes, patch)
2015-03-09 09:21 UTC, MailMr_S 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description MailMr_S 2015-03-09 09:21:00 UTC 
Created attachment 2059 [details]
Patch to fix

The template file (include/SDL_config.h.cmake) has only one HAVE_DXGI_H for DirectX header configuration. But in src/core/windows/SDL_directx.h you also need HAVE_DDRAW_H, HAVE_DSOUND_H and HAVE_DINPUT_H.
Comment 1 Johan Euphrosine 2015-03-13 23:54:31 UTC 
+1, it also fixed the build on windows 8.1 with DirectX SDK 2010 for me.
Comment 2 Ryan C. Gordon 2015-05-27 01:10:17 UTC 
This patch is now https://hg.libsdl.org/SDL/rev/5ab832f7bc38, thanks!

--ryan.