We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2885 - SDL_stdinc.h doesn't need to include iconv.h ...
Summary: SDL_stdinc.h doesn't need to include iconv.h ...
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: *don't know* (show other bugs)
Version: HG 2.0
Hardware: All All
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-20 02:18 UTC by Ryan C. Gordon
Modified: 2016-10-07 23:45 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan C. Gordon 2015-02-20 02:18:02 UTC 
We still include iconv.h in SDL_stdinc.h, probably because this header might have referenced the native iconv functions and types directly. Since these are hidden behind a stable ABI now and never just a #define for the system iconv, we shouldn't need this header included from a public SDL header anymore, slowing down external apps compiles and pulling tons of stuff into the namespace.

math.h, float.h, ctype.h, etc might also be able to be removed too.

--ryan.
Comment 1 Sam Lantinga 2016-10-07 23:45:43 UTC 
Fixed, thanks!
https://hg.libsdl.org/SDL/rev/42a679ff48e0