We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2881 - Fix extraneous parenthesis warning from clang
Summary: Fix extraneous parenthesis warning from clang
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: haptic (show other bugs)
Version: HG 2.0
Hardware: x86_64 Linux
: P5 trivial
Assignee: Edgar Simo
QA Contact: Sam Lantinga
URL:
Keywords: triage-2.0.4
Depends on:
Blocks:
 
Reported: 2015-02-15 23:14 UTC by Simon Deschenes
Modified: 2015-02-19 18:11 UTC (History)
1 user (show)

See Also:

Attachments
The patch (694 bytes, patch)
2015-02-15 23:16 UTC, Simon Deschenes 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Deschenes 2015-02-15 23:14:33 UTC 
My build system considers warnings as errors, and this was a little warning about extraneous parenthesis I fixed.

In src/haptic/linux/SDL_syshaptic.c
Comment 1 Simon Deschenes 2015-02-15 23:16:57 UTC 
Created attachment 2034 [details]
The patch
Comment 2 Simon Deschenes 2015-02-15 23:21:59 UTC 
in fact :
SDL_free(item->fname);

is also useless as item->fname is NULL
Comment 3 Ryan C. Gordon 2015-02-19 05:22:17 UTC 
Marking a large number of bugs with the "triage-2.0.4" keyword at once. Sorry if you got a lot of email from this. This is to help me sort through some bugs in regards to a 2.0.4 release. We may or may not fix this bug for 2.0.4, though!
Comment 4 Ryan C. Gordon 2015-02-19 18:11:55 UTC 
Fixed in https://hg.libsdl.org/SDL/rev/c671d8ca48a1

Thanks!

--ryan.