This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

• Patch to use some modern Mac APIs rather than deprecated ones, when available (SDL_mac_deprecations.diff, text/plain, 2015-01-27 18:56:11 +0000, 4484 bytes)
• Patch to use some modern Mac APIs rather than deprecated ones, when available (SDL_mac_deprecations_2.diff, text/plain, 2015-01-27 20:44:17 +0000, 4385 bytes)
• Patch to prefer some modern Mac APIs over deprecated ones (v3) (SDL_mac_deprecations_3.diff, text/plain, 2015-02-02 07:45:36 +0000, 4912 bytes)
• Patch to prefer some modern Mac APIs over deprecated ones (v4) (SDL_mac_deprecations_4.diff, text/plain, 2015-02-02 09:20:23 +0000, 5108 bytes)

Reported in version: HG 2.0
Reported for operating system, platform: Mac OS X (All), x86_64

Comments on the original bug report:

On 2015-01-27 18:56:11 +0000, Alex Szpakowski wrote:

Created attachment 2007
Patch to use some modern Mac APIs rather than deprecated ones, when available

SDL's Mac code for preventing the screensaver from activating and for making the app show up in the Dock is using long-deprecated APIs. I have attached a patch to use more modern APIs when available.

On 2015-01-27 20:44:17 +0000, Alex Szpakowski wrote:

Created attachment 2008
Patch to use some modern Mac APIs rather than deprecated ones, when available

On 2015-02-02 07:04:02 +0000, Ryan C. Gordon wrote:

(In reply to Alex Szpakowski from comment # 1)

Created attachment 2008 [details]
Patch to use some modern Mac APIs rather than deprecated ones, when available

Notes:

• Cocoa_ShouldUseIdleIOPMAssertion() should just be checked once at init time and stored as a BOOL somewhere under _this. Not that it's a real expensive function or anything, of course.

• Put a FIXME or something on this: CFSTR("SDL-based app running") ... eventually I'd like to add a simple app metadata API that lets an app describe some basic things about itself, since there are a few places on various platforms where we end up saying "SDL application" instead of "Super Mario Bros."

• Does the legacy path not need to call SetFrontProcess()? That got removed in the patch.

--ryan.

On 2015-02-02 07:33:32 +0000, Alex Szpakowski wrote:

(In reply to Ryan C. Gordon from comment # 2)

• Put a FIXME or something on this: CFSTR("SDL-based app running") ...
  eventually I'd like to add a simple app metadata API that lets an app
  describe some basic things about itself, since there are a few places on
  various platforms where we end up saying "SDL application" instead of "Super
  Mario Bros."

Should I just make it use the actual application name? SDL_cocoaevents.m already has a function to determine it, since it creates the menubar items programmatically.

(In reply to Ryan C. Gordon from comment # 2)

• Does the legacy path not need to call SetFrontProcess()? That got removed
  in the patch.

--ryan.

The patch replaces the SetFrontProcess call with [NSApp activateIgnoringOtherApps:YES] (the Cocoa version of that Carbon function.)

On 2015-02-02 07:37:34 +0000, Alex Szpakowski wrote:

(In reply to Alex Szpakowski from comment # 3)

Should I just make it use the actual application name? SDL_cocoaevents.m
already has a function to determine it, since it creates the menubar items
programmatically.

Actually the Apple documentation says this, so I guess the app name isn't quite appropriate:

specify a CFString like "Checking mail" or "Compiling" that describes the task that this assertion protects.

On 2015-02-02 07:45:36 +0000, Alex Szpakowski wrote:

Created attachment 2013
Patch to prefer some modern Mac APIs over deprecated ones (v3)

On 2015-02-02 09:20:23 +0000, Alex Szpakowski wrote:

Created attachment 2014
Patch to prefer some modern Mac APIs over deprecated ones (v4)

I updated the name used in IOPMAssertionCreate to include the application name, and added a comment about it.

On 2015-02-19 05:22:19 +0000, Ryan C. Gordon wrote:

Marking a large number of bugs with the "triage-2.0.4" keyword at once. Sorry if you got a lot of email from this. This is to help me sort through some bugs in regards to a 2.0.4 release. We may or may not fix this bug for 2.0.4, though!

On 2015-02-20 01:06:43 +0000, Ryan C. Gordon wrote:

This looks good to me; it's now https://hg.libsdl.org/SDL/rev/ad9d35983de5, thanks!

--ryan.