We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2855 - [PATCH] Segfault CreateMIDIEventList
Summary: [PATCH] Segfault CreateMIDIEventList
Status: RESOLVED FIXED
Alias: None
Product: SDL_mixer
Classification: Unclassified
Component: misc (show other bugs)
Version: unspecified
Hardware: x86_64 All
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-24 23:13 UTC by Jean-Baptiste Noblot
Modified: 2017-10-13 06:19 UTC (History)
0 users

See Also:

Attachments
A Patch to solve Segfault (468 bytes, patch)
2015-01-24 23:13 UTC, Jean-Baptiste Noblot 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Baptiste Noblot 2015-01-24 23:13:13 UTC 
Created attachment 2003 [details]
A Patch to solve Segfault

A Segfault is possible because eventList line 383 (native_midi_common.c)
is affected with MIDItoStream and is possible to return NULL without set mididata->tracks. But 2 lines later we use 
mididata->tracks[trackID](SEGFAULT)
Comment 1 Sam Lantinga 2017-10-13 06:19:43 UTC 
Fixed, thanks!
https://hg.libsdl.org/SDL_mixer/rev/4bb26a86096e