Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hint to set resource id for window icon #1741

Closed
SDLBugzilla opened this issue Feb 10, 2021 · 0 comments
Closed

Hint to set resource id for window icon #1741

SDLBugzilla opened this issue Feb 10, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: 2.0.3
Reported for operating system, platform: Windows (All), x86

Comments on the original bug report:

On 2015-01-10 17:55:53 +0000, Alexey wrote:

Created attachment 1989
patch

Seems to be a missing functionality. I want to set an icon from RC file. I cant pass MAKEINTRESOURCE(X) string to SDL_RegisterApp() cause string returned by MAKEINTRESOURCE string is not actually a string and SDL_strlen will crash. Moreover LoadImage seems to be loading wrong icon size. LoadIcon seems to be fine.

On 2017-03-04 03:36:38 +0000, wrote:

I too wish for something of the sort, and apparently so do n amount of stackoverflow and github gisters. We need a standard way to do this for the windows platform.

On 2017-08-13 21:17:09 +0000, Sam Lantinga wrote:

I added two hints, one for the large and one for the small icon:
SDL_HINT_WINDOWS_INTRESOURCE_ICON
SDL_HINT_WINDOWS_INTRESOURCE_ICON_SMALL

https://hg.libsdl.org/SDL/rev/2d458a198021

Thanks!

@SDLBugzilla SDLBugzilla added the enhancement New feature or request label Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant