Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL_RenderCopy is extremely slow on iOS device after Emscripten commit #1729

Closed
SDLBugzilla opened this issue Feb 10, 2021 · 0 comments
Closed
Labels
abandoned Bug has been abandoned for various reasons

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

Reported in version: HG 2.1
Reported for operating system, platform: iOS (All), iPhone/iPod touch

Comments on the original bug report:

On 2014-12-26 14:33:39 +0000, Diego wrote:

Running happy.c from Xcode-iOS Demos project on a device produces this problem.
After changeset 9278 8900afb78a19, SDL_RenderCopy is slow on iOS devices. Timing happy.c's "render(renderer)" function produces ~200ms on 4S iOS 8, and ~100ms on 5C iOS 8.
The previous changeset 9277 f0bd40782fc7, runs as expected at ~5ms.
This slowdown does not occur on the simulator.

On 2014-12-26 19:59:03 +0000, Ryan C. Gordon wrote:

Can you go find GLES2_UpdateVertexBuffer() in src/render/opengles2/SDL_render_gles2.c?

https://hg.libsdl.org/SDL/file/8900afb78a19/src/render/opengles2/SDL_render_gles2.c#l1391

That "#if 0" line? Make that into "#if 1" and rebuild SDL and your app. Does that fix the problem?

--ryan.

On 2014-12-26 20:48:04 +0000, Diego wrote:

Changing to "#if 1" worked!

On 2014-12-27 03:31:40 +0000, Ryan C. Gordon wrote:

Ok, this should be fixed by https://hg.libsdl.org/SDL/rev/1d3bee66d518

I'm going to leave this bug assigned, because we should fix this properly after 2.0.4 ships, but the patch should make both Emscripten and iOS happy for now.

--ryan.

On 2018-08-06 21:20:22 +0000, Ryan C. Gordon wrote:

Hello, and sorry if you're getting dozens of copies of this message by email.

We are closing out bugs that appear to be abandoned in some form. This can happen for lots of reasons: we couldn't reproduce it, conversation faded out, the bug was noted as fixed in a comment but we forgot to mark it resolved, the report is good but the fix is impractical, we fixed it a long time ago without realizing there was an associated report, etc.

Individually, any of these bugs might have a better resolution (such as WONTFIX or WORKSFORME or INVALID) but we've added a new resolution of ABANDONED to make this easily searchable and make it clear that it's not necessarily unreasonable to revive a given bug report.

So if this bug is still a going concern and you feel it should still be open: please feel free to reopen it! But unless you respond, we'd like to consider these bugs closed, as many of them are several years old and overwhelming our ability to prioritize recent issues.

(please note that hundred of bug reports were sorted through here, so we apologize for any human error. Just reopen the bug in that case!)

Thanks,
--ryan.

@SDLBugzilla SDLBugzilla added abandoned Bug has been abandoned for various reasons bug labels Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned Bug has been abandoned for various reasons
Projects
None yet
Development

No branches or pull requests

1 participant