Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Fix android build compiling in wrong filesystem implementation #1705

Closed
SDLBugzilla opened this issue Feb 10, 2021 · 0 comments
Closed

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: HG 2.1
Reported for operating system, platform: Android (All), All

Comments on the original bug report:

On 2014-12-05 13:18:40 +0000, Jonas Kulla wrote:

Created attachment 1953
patch

The configure script didn't differentiate between Linux and Android, unconditionally compiling in the unix implementation of SDL_sysfilesystem.c.

'm probably one of the very few people building SDL for android using classic configure + standalone toolchain, so this has gone undetected all along.

On 2014-12-05 13:30:29 +0000, Jonas Kulla wrote:

Created attachment 1954
patch

Forgot that you guys keep the generated configure script in revision too.

On 2015-01-26 21:42:59 +0000, Philipp Wiesemann wrote:

Thank you for the patch. It was applied here:
https://hg.libsdl.org/SDL/rev/541f12d1edcd

I missed that it broke the configure script for FreeBSD (neither Android nor Linux but needs a filesystem implementation). This was fixed here:
https://hg.libsdl.org/SDL/rev/3ad27ca380f3

On 2015-01-28 06:36:10 +0000, Jonas Kulla wrote:

Ah, my bad, I should have seen that one coming. Thanks for applying and fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant