We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2802 - [patch] Fix android build compiling in wrong filesystem implementation
Summary: [patch] Fix android build compiling in wrong filesystem implementation
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: build (show other bugs)
Version: HG 2.1
Hardware: All Android (All)
: P2 normal
Assignee: Gabriel Jacobo
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-05 13:18 UTC by Jonas Kulla
Modified: 2015-01-28 06:36 UTC (History)
2 users (show)

See Also:

Attachments
patch (1.34 KB, patch)
2014-12-05 13:18 UTC, Jonas Kulla 		Details | Diff
patch (2.26 KB, patch)
2014-12-05 13:30 UTC, Jonas Kulla 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonas Kulla 2014-12-05 13:18:40 UTC 
Created attachment 1953 [details]
patch

The configure script didn't differentiate between Linux and Android,  unconditionally compiling in the unix implementation of SDL_sysfilesystem.c.

'm probably one of the very few people building SDL for android using classic configure + standalone toolchain, so this has gone undetected all along.
Comment 1 Jonas Kulla 2014-12-05 13:30:29 UTC 
Created attachment 1954 [details]
patch

Forgot that you guys keep the generated configure script in revision too.
Comment 2 Philipp Wiesemann 2015-01-26 21:42:59 UTC 
Thank you for the patch. It was applied here:
https://hg.libsdl.org/SDL/rev/541f12d1edcd

I missed that it broke the configure script for FreeBSD (neither Android nor Linux but needs a filesystem implementation). This was fixed here:
https://hg.libsdl.org/SDL/rev/3ad27ca380f3
Comment 3 Jonas Kulla 2015-01-28 06:36:10 UTC 
Ah, my bad, I should have seen that one coming. Thanks for applying and fixing it!