We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2797 - [patch] Fix android build with disabled audio subsystem
Summary: [patch] Fix android build with disabled audio subsystem
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: video (show other bugs)
Version: HG 2.1
Hardware: All Android (All)
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords: triage-2.0.4
Depends on:
Blocks:
 
Reported: 2014-12-02 07:27 UTC by Jonas Kulla
Modified: 2015-04-05 19:58 UTC (History)
2 users (show)

See Also:

Attachments
patch (559 bytes, patch)
2014-12-02 07:27 UTC, Jonas Kulla 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonas Kulla 2014-12-02 07:27:02 UTC 
Created attachment 1950 [details]
patch

src/video/android/SDL_androidevents.c declares and uses audio subsystem functions (AndroidAUD_ResumeDevices, AndroidAUD_PauseDevices) that are not compiled in when the audio subsystem is disabled during configure.
Check for that case and define the functions as noops instead.

Not sure if you'd rather prefer to have every function call ifdef-d out instead, but I think using stubs is less invasive.
Comment 1 Ryan C. Gordon 2015-02-19 05:22:20 UTC 
Marking a large number of bugs with the "triage-2.0.4" keyword at once. Sorry if you got a lot of email from this. This is to help me sort through some bugs in regards to a 2.0.4 release. We may or may not fix this bug for 2.0.4, though!
Comment 2 Ryan C. Gordon 2015-04-05 19:58:55 UTC 
This patch is now http://hg.libsdl.org/SDL/rev/b452e37e26d9, thanks!

--ryan.