We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2720 - erroneous definition of DECLSPEC in begin_code.h
Summary: erroneous definition of DECLSPEC in begin_code.h
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: build (show other bugs)
Version: HG 2.0
Hardware: x86 Linux
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords: target-2.0.4, triage-2.0.4
Depends on:
Blocks:
 
Reported: 2014-09-08 10:32 UTC by Ozkan Sezer
Modified: 2015-05-26 20:44 UTC (History)
1 user (show)

See Also:

Attachments
fix begin_code.h (DECLSPEC) for non-WIN32 and gcc < 4.x (625 bytes, patch)
2014-09-08 10:32 UTC, Ozkan Sezer 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ozkan Sezer 2014-09-08 10:32:40 UTC 
Created attachment 1862 [details]
fix begin_code.h (DECLSPEC) for non-WIN32 and gcc < 4.x

The attached patch removes a leftover definition of DECLSPEC as dllexport
for non-WIN32 cases, which used to break compilations with gcc-3.x.
Comment 1 Ryan C. Gordon 2015-02-19 05:22:21 UTC 
Marking a large number of bugs with the "triage-2.0.4" keyword at once. Sorry if you got a lot of email from this. This is to help me sort through some bugs in regards to a 2.0.4 release. We may or may not fix this bug for 2.0.4, though!
Comment 2 Ryan C. Gordon 2015-04-07 04:57:58 UTC 
(sorry if you get a lot of copies of this email, I'm marking several bugs at once)

Marking bugs for the (mostly) final 2.0.4 TODO list. This means we're hoping to resolve this bug before 2.0.4 ships if possible. In a perfect world, the open bug count with the target-2.0.4 keyword is zero when we ship.

(Note that closing a bug report as WONTFIX, INVALID or WORKSFORME might still happen.)

--ryan.
Comment 3 Ryan C. Gordon 2015-05-26 20:44:49 UTC 
This should be fixed by https://hg.libsdl.org/SDL/rev/7e843b8b8301, thanks!

--ryan.