We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2676 - xdnd_version check issue in case ClientMessage:
Summary: xdnd_version check issue in case ClientMessage:
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: video (show other bugs)
Version: 2.0.3
Hardware: x86 Linux
: P2 major
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-08 10:16 UTC by Nitz
Modified: 2014-11-28 12:43 UTC (History)
0 users

See Also:

Attachments
patch (1.51 KB, text/plain)
2014-08-08 10:16 UTC, Nitz 		Details
patch (2.51 KB, text/plain)
2014-09-05 06:12 UTC, Nitz 		Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nitz 2014-08-08 10:16:18 UTC 
Created attachment 1805 [details]
patch

In X11_DispatchEvent(_THIS) function:
case ClientMessage:

In that, value of 32 bit data shifted to 24 bits which is assigned to xdnd_version

But xdnd_version has no effect on 
XdndEnter,
XdndPosition,
XdndDrop,
neither of the cases

So I think it would be better if we removed the check of xdnd_version
Comment 1 Sam Lantinga 2014-08-17 22:17:55 UTC 
Should the check be added to the other cases? What's the impact of removing that check?
Comment 2 Nitz 2014-09-05 06:10:58 UTC 
I added xdnd_version check to XdndPosition case also
under DEBUG_XEVENTS macro.
by this we can get the action requested by user.

I analysed further and found out that removing xdnd_version check at XdndDrop case is a bad idea because 
in XConvertSelection API timestamp should be passed if(xdnd_version >= 1)
otherwise CurrentTime should be passed
So xdnd_version check is important at XdndDrop case

I made xdnd_version as a static so that it can store the version in other cases also.

Patch is attached.

Thanks!!!
Comment 3 Nitz 2014-09-05 06:12:27 UTC 
Created attachment 1860 [details]
patch
Comment 4 Nitz 2014-10-27 11:50:23 UTC 
A gentle reminder.

Thanks!!!
Comment 5 Nitz 2014-11-14 03:57:23 UTC 
A gentle reminder
Thanks!!!
Comment 6 Sam Lantinga 2014-11-28 12:43:17 UTC 
Fixed, thanks!
https://hg.libsdl.org/SDL/rev/104f3bcfbf45