We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2674 - dollar gesture loading is not endian safe
Summary: dollar gesture loading is not endian safe
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: *don't know* (show other bugs)
Version: HG 2.1
Hardware: All All
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords: triage-2.0.4
Depends on:
Blocks:
 
Reported: 2014-08-07 05:57 UTC by Martin Gerhardy
Modified: 2015-04-05 23:03 UTC (History)
2 users (show)

See Also:

Attachments
endian safetly for dollar gestures (2.22 KB, patch)
2014-08-07 05:57 UTC, Martin Gerhardy 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Gerhardy 2014-08-07 05:57:49 UTC 
Created attachment 1804 [details]
endian safetly for dollar gestures

the saving and loading of dollar gesture is not endian safe. The attached patch should fix this.
Comment 1 Philipp Wiesemann 2014-08-08 08:19:27 UTC 
(In reply to Martin Gerhardy from comment #0)
> Created attachment 1804 [details]
> endian safetly for dollar gestures
> 
> the saving and loading of dollar gesture is not endian safe. The attached
> patch should fix this.

The patch changes SDL_LoadDollarTemplates() to return -1 instead of 0 if nothing was loaded.
Comment 2 Ryan C. Gordon 2015-02-19 05:22:17 UTC 
Marking a large number of bugs with the "triage-2.0.4" keyword at once. Sorry if you got a lot of email from this. This is to help me sort through some bugs in regards to a 2.0.4 release. We may or may not fix this bug for 2.0.4, though!
Comment 3 Ryan C. Gordon 2015-04-05 23:03:04 UTC 
(In reply to Philipp Wiesemann from comment #1)
> The patch changes SDL_LoadDollarTemplates() to return -1 instead of 0 if
> nothing was loaded.

I decided this one was okay.

Something based on Martin's patch is now https://hg.libsdl.org/SDL/rev/9f2beba999b8, thanks!

--ryan.