We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2673 - dollar gesture loading does not set an error
Summary: dollar gesture loading does not set an error
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: *don't know* (show other bugs)
Version: HG 2.1
Hardware: All All
: P2 enhancement
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords: triage-2.0.4
Depends on:
Blocks:
 
Reported: 2014-08-06 20:49 UTC by Martin Gerhardy
Modified: 2015-04-05 22:45 UTC (History)
1 user (show)

See Also:

Attachments
call SDL_SetError to describe a little bit what went wrong (1.53 KB, patch)
2014-08-06 20:49 UTC, Martin Gerhardy 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Gerhardy 2014-08-06 20:49:44 UTC 
Created attachment 1803 [details]
call SDL_SetError to describe a little bit what went wrong

attached is a small patch that improves the situation a little bit.
Comment 1 Philipp Wiesemann 2014-08-08 08:06:52 UTC 
(In reply to Martin Gerhardy from comment #0)
> Created attachment 1803 [details]
> call SDL_SetError to describe a little bit what went wrong
> 
> attached is a small patch that improves the situation a little bit.

The patch also changes SDL_LoadDollarTemplates() to return -1 instead of 0 if src == NULL. Although it may make more sense this it could break existing programs.
Comment 2 Ryan C. Gordon 2015-02-19 05:22:22 UTC 
Marking a large number of bugs with the "triage-2.0.4" keyword at once. Sorry if you got a lot of email from this. This is to help me sort through some bugs in regards to a 2.0.4 release. We may or may not fix this bug for 2.0.4, though!
Comment 3 Ryan C. Gordon 2015-04-05 22:45:31 UTC 
This patch (with the one "return 0" restored) is now http://hg.libsdl.org/SDL/rev/2d6ec08030a0, thanks!

--ryan.