We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2672 - Logic getting duplicate in SDL_UpperBlitScaled function
Summary: Logic getting duplicate in SDL_UpperBlitScaled function
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: video (show other bugs)
Version: 2.0.3
Hardware: x86 Linux
: P2 critical
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-06 10:27 UTC by Nitz
Modified: 2014-08-17 23:34 UTC (History)
1 user (show)

See Also:

Attachments
duplicate logic code removed (875 bytes, text/plain)
2014-08-06 10:27 UTC, Nitz 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nitz 2014-08-06 10:27:39 UTC 
Created attachment 1802 [details]
duplicate logic code removed

In function SDL_UpperBlitScaled(SDL_Surface * src, const SDL_Rect * srcrect,
              SDL_Surface * dst, SDL_Rect * dstrect)

Here when dstrect is NULL, in this case logic getting duplicate for
copy image into the entire dst surface.

Patch is attached.

Thanks!!!
Comment 1 Robotic-Brain 2014-08-17 22:44:12 UTC 
Outdated by https://hg.libsdl.org/SDL/rev/5e713281410c
Comment 2 Sam Lantinga 2014-08-17 23:34:39 UTC 
This is fixed, thanks!