We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2664 - GCC warning about _MSC_VER with -Wundef in SDL_stdinc.h
Summary: GCC warning about _MSC_VER with -Wundef in SDL_stdinc.h
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: *don't know* (show other bugs)
Version: HG 2.1
Hardware: All Linux
: P2 trivial
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords: target-2.0.4, triage-2.0.4
Depends on:
Blocks:
 
Reported: 2014-07-29 20:14 UTC by Ben Swick
Modified: 2015-04-08 05:44 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Swick 2014-07-29 20:14:39 UTC 
Line 203 of SDL_stdinc.h (current checkout from HG) checks the value of _MSC_VER without checking if it is defined first. The GCC flag -Wundef triggers a warning about the undefined macro.

#if _MSC_VER >= 1600 /* VS 2010 and above */

should be:

#if defined(_MSC_VER) && _MSC_VER >= 1600 /* VS 2010 and above */
Comment 1 historic_bruno 2015-01-18 08:52:19 UTC 
Not only GCC, I get the same warnings with clang on OS X.
Comment 2 Ryan C. Gordon 2015-02-19 05:22:19 UTC 
Marking a large number of bugs with the "triage-2.0.4" keyword at once. Sorry if you got a lot of email from this. This is to help me sort through some bugs in regards to a 2.0.4 release. We may or may not fix this bug for 2.0.4, though!
Comment 3 Ryan C. Gordon 2015-04-07 04:57:54 UTC 
(sorry if you get a lot of copies of this email, I'm marking several bugs at once)

Marking bugs for the (mostly) final 2.0.4 TODO list. This means we're hoping to resolve this bug before 2.0.4 ships if possible. In a perfect world, the open bug count with the target-2.0.4 keyword is zero when we ship.

(Note that closing a bug report as WONTFIX, INVALID or WORKSFORME might still happen.)

--ryan.
Comment 4 Ryan C. Gordon 2015-04-08 05:44:13 UTC 
This is fixed in https://hg.libsdl.org/SDL/rev/61f57bbbc2f3, thanks!

--ryan.