We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2650 - Cocoa_WarpMouseGlobal missing conditional
Summary: Cocoa_WarpMouseGlobal missing conditional
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: events (show other bugs)
Version: don't know
Hardware: All Mac OS X 10.8
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-18 06:00 UTC by Tim McDaniel
Modified: 2014-08-18 01:40 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim McDaniel 2014-07-18 06:00:20 UTC 
Reviewing current revision 9008 code, against the 2.0.3 release, I see that Cocoa_WarpMouseGlobal is missing the code dealing with the conditional "if ([data->listener isMoving])", as at the top of Cocoa_WarpMouse.  This extra bit of code handles the case of attempting to warp the mouse when the window is being moved by user, which will result in the window snapping to weird locations, and other evil.  Although I have not directly tested Cocoa_WarpMouseGlobal, it is difficult to see how it would not suffer the same evil behavior since it is currently missing that bit of code.

Cheers
Comment 1 Robotic-Brain 2014-08-18 01:40:33 UTC 
Fixed by https://hg.libsdl.org/SDL/rev/c5e33f9a0d03