We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2631 - [Patch] Mac: minor code cleanup
Summary: [Patch] Mac: minor code cleanup
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: video (show other bugs)
Version: HG 2.0
Hardware: x86 Mac OS X (All)
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
: 2905 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-07-07 19:41 UTC by Alex Szpakowski
Modified: 2015-03-12 02:49 UTC (History)
1 user (show)

See Also:

Attachments
Minor code cleanup in Mac backend files (32.09 KB, patch)
2014-07-07 19:41 UTC, Alex Szpakowski 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Szpakowski 2014-07-07 19:41:54 UTC 
Created attachment 1739 [details]
Minor code cleanup in Mac backend files

Some minor changes to the Mac-specific backend code:

- Fixed up some code style issues (mostly brace style inconsistencies).

- Fixed a compiler warning in SDL_cocoaevents.m.

- Removed some useless code now that the 10.7 SDK is required to build SDL.

- Removed Gestalt(gestaltSystemVersion, ...) call and switched to NSAppKitVersionNumber for version checking code. Using Gestalt with gestaltSystemVersion will give 0x1090 in Mac OS 10.10+, and the whole Gestalt function was deprecated in Mac OS 10.8.
Comment 1 Sam Lantinga 2014-07-07 19:49:39 UTC 
Applied, thanks!
https://hg.libsdl.org/SDL/rev/1c81316ac642
Comment 2 Alex Szpakowski 2015-03-12 02:49:26 UTC 
*** Bug 2905 has been marked as a duplicate of this bug. ***