We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 2606 - X11: Value stored to 'xdnd_version' is never read
Summary: X11: Value stored to 'xdnd_version' is never read
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: events (show other bugs)
Version: HG 2.0
Hardware: All Linux
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords: target-2.0.4
Depends on:
Blocks:
 
Reported: 2014-06-26 01:39 UTC by Ryan C. Gordon
Modified: 2015-05-28 20:12 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan C. Gordon 2014-06-26 01:39:37 UTC 
Static analysis saw this...

https://buildbot.libsdl.org/sdl-static-analysis/sdl-macosx-static-analysis/sdl-macosx-static-analysis-186/report-122653.html#EndPath

We assign xdnd_version only on XdndEnter events, but we only read it in the "else" blocks, so it's always zero, the original initializer value, when we check it.

This is probably wrong.

--ryan.
Comment 1 Ryan C. Gordon 2015-02-19 05:22:19 UTC 
Marking a large number of bugs with the "triage-2.0.4" keyword at once. Sorry if you got a lot of email from this. This is to help me sort through some bugs in regards to a 2.0.4 release. We may or may not fix this bug for 2.0.4, though!
Comment 2 Ryan C. Gordon 2015-04-07 04:57:56 UTC 
(sorry if you get a lot of copies of this email, I'm marking several bugs at once)

Marking bugs for the (mostly) final 2.0.4 TODO list. This means we're hoping to resolve this bug before 2.0.4 ships if possible. In a perfect world, the open bug count with the target-2.0.4 keyword is zero when we ship.

(Note that closing a bug report as WONTFIX, INVALID or WORKSFORME might still happen.)

--ryan.
Comment 3 Sam Lantinga 2015-05-28 17:08:46 UTC 
It looks like this has been fixed by making the version static, resolved in bug 2676
Comment 4 Ryan C. Gordon 2015-05-28 20:12:02 UTC 
Yep, cool.

--ryan.