Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backing store prevents page flipping with current Xorg DRI2 #752

Closed
SDLBugzilla opened this issue Feb 10, 2021 · 0 comments
Closed

Backing store prevents page flipping with current Xorg DRI2 #752

SDLBugzilla opened this issue Feb 10, 2021 · 0 comments
Labels
endoflife Bug might be valid, but SDL-1.2 is EOL.

Comments

@SDLBugzilla
Copy link
Collaborator

SDLBugzilla commented Feb 10, 2021

This bug report was migrated from our old Bugzilla tracker.

Reported in version: HG 1.2
Reported for operating system, platform: Linux, Other

Comments on the original bug report:

On 2014-06-24 08:37:12 +0000, Michel Dänzer wrote:

src/video/x11/SDL_x11video.c:X11_CreateWindow() contains the code below, which enables backing store if the X server supports it. Current Xorg implements backing store by redirecting the window storage to a separate pixmap using the composite layer. This prevents windows with backing store enabled from using page flipping for DRI2 buffer swaps. Instead, a buffer swap requires two copies (one from the DRI2 back buffer to the window pixmap, and one from the window pixmap to the screen pixmap), which might reduce performance significantly and causes visible tearing such as described in https://bugs.freedesktop.org/show_bug.cgi?id=79850 .

SDL2 doesn't seem to have this code anymore, so I think it would be be best to disable it by default, if not remove it altogether.

#if 0 /* This is an experiment - are the graphics faster now? - nope. */
	if ( SDL_getenv("SDL_VIDEO_X11_BACKINGSTORE") )
#endif
	/* Cache the window in the server, when possible */
	{
		Screen *xscreen;
		XSetWindowAttributes a;

		xscreen = ScreenOfDisplay(SDL_Display, SDL_Screen);
		a.backing_store = DoesBackingStore(xscreen);
		if ( a.backing_store != NotUseful ) {
			XChangeWindowAttributes(SDL_Display, SDL_Window,
			                        CWBackingStore, &a);
		}
	}

On 2015-08-25 09:38:21 +0000, Ryan C. Gordon wrote:

Hello, and sorry if you're getting several copies of this message by email, since we are closing many bugs at once here.

We have decided to mark all SDL 1.2-related bugs as RESOLVED ENDOFLIFE, as we don't intend to work on SDL 1.2 any further, but didn't want to mark a large quantity of bugs as RESOLVED WONTFIX, to clearly show what was left unattended to and make it easily searchable.

Our current focus is on SDL 2.0.

If you are still having problems with an ENDOFLIFE bug, your absolute best option is to move your program to SDL2, as it will likely fix the problem by default, and give you access to modern platforms and tons of super-cool new features.

Failing that, we will accept small patches to fix these issues, and put them in revision control, although we do not intend to do any further official 1.2 releases.

Failing that, please feel free to contact me directly by email (icculus@icculus.org) and we'll try to find some way to help you out of your situation.

Thank you,
--ryan.

On 2018-08-13 07:22:34 +0000, Rene Dudfield wrote:

This is a duplicate of https://bugzilla.libsdl.org/show_bug.cgi?id=2383

Arch Linux patches SDL for this issue here: https://git.archlinux.org/svntogit/packages.git/tree/trunk/SDL-1.2.15-no-default-backing-store.patch?h=packages/sdl

@SDLBugzilla SDLBugzilla added bug endoflife Bug might be valid, but SDL-1.2 is EOL. labels Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
endoflife Bug might be valid, but SDL-1.2 is EOL.
Projects
None yet
Development

No branches or pull requests

1 participant